FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

server: acquire IPv4 address when add secondary IP to nic if IP is not specified by ustcweizhou · Pull Request #3635 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

server: acquire IPv4 address when add secondary IP to nic if IP is not specified - #3635

Merged
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:acquire-secondary-ipv4-by-default
Nov 21, 2019
ConversationCommits (1)ChecksFiles changed
Merged

server: acquire IPv4 address when add secondary IP to nic if IP is not specified#3635
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:acquire-secondary-ipv4-by-default

Conversation

ustcweizhou commented Oct 15, 2019

Copy link
Copy Markdown
Contributor

Description

After commit fbf4884, admin need to specify an ipv4 or ipv6 addresses when add IP to nic which breaks backward compatibity. If IP is not specified, a IPv4 address should be returned.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

When I add an IP to a nic and do not specify an IP,

Before this PR, it gives an error "Allocating ip to guest nic 111 failed"
After this PR, it succeeds.

server: acquire IPv4 address when add secondary IP to nic if IP is no…
a461839 
…t specified

After commit fbf4884, admin need to specify an ipv4 or ipv6 addresses when add IP to nic which breaks backward compatibity. If IP is not specified, a IPv4 address should be returned.

ustcweizhou commented Oct 15, 2019

Copy link
Copy Markdown
Contributor Author

@wido @GabrielBrascher @rhtyd
can you please review and test it ?

ustcweizhou mentioned this pull request Oct 15, 2019
Merged
1 of 5 tasks
GabrielBrascher approved these changes Oct 15, 2019
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code LGTM, thanks @ustcweizhou.

ustcweizhou mentioned this pull request Oct 17, 2019
Merged
1 of 5 tasks
yadvr added this to the 4.13.1.0 milestone Oct 22, 2019

yadvr commented Nov 11, 2019

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Nov 11, 2019

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Nov 11, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-344

DaanHoogland commented Nov 20, 2019

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Nov 20, 2019

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Nov 20, 2019

Copy link
Copy Markdown

Trillian test result (tid-503)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27830 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3635-t503-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

yadvr merged commit d981edb into apache:4.13 Nov 21, 2019
ustcweizhou added a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
server: acquire IPv4 address when add secondary IP to nic if IP is no…
0c484b7 
…t specified (apache#3635)

After commit fbf4884, admin need to specify an ipv4 or ipv6 addresses when add IP to nic which breaks backward compatibity. If IP is not specified, a IPv4 address should be returned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland left review comments
weizhouapache weizhouapache left review comments
yadvr yadvr approved these changes
GabrielBrascher GabrielBrascher approved these changes

Assignees

No one assigned

Labels

component:networking type:bug

Projects

None yet

Milestone

4.13.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL