Repository navigation
kvm: fix issue that network rules for secondary IPs are not applied - #3636
Merged
yadvr merged 1 commit intoNov 21, 2019
Merged
yadvr merged 1 commit into
yadvr merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When I add a secondary IP to a nic on shared network in advanced zone with security groups, the network rules for new IP are not applied on KVM hypervisors. It is because "--action -A" cannot be recognized in security_group.py after commit ac73e7e. changing to "--action=-A" will fix it.
Copy link
Copy Markdown
Contributor
Author
|
@wido @GabrielBrascher could you please review and test it ? |
Sorry, something went wrong.
Merged
1 of 5 tasks
Copy link
Copy Markdown
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-343 |
Sorry, something went wrong.
GabrielBrascher
approved these changes
Nov 13, 2019
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Code LGTM. Tested and it works.
Sorry, something went wrong.
yadvr
approved these changes
Nov 21, 2019
Copy link
Copy Markdown
Member
|
Requires SG env that BO cannot kick by default, since manually tested, not kicking explicit test. |
Sorry, something went wrong.
ustcweizhou
added a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
…pache#3636) When I add a secondary IP to a nic on shared network in advanced zone with security groups, the network rules for new IP are not applied on KVM hypervisors. It is because "--action -A" cannot be recognized in security_group.py after commit ac73e7e. changing to "--action=-A" will fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When I add a secondary IP to a nic on shared network in advanced zone with security groups, the network rules for new IP are not applied on KVM hypervisors.
It is because "--action -A" cannot be recognized in security_group.py after commit ac73e7e. changing to "--action=-A" will fix it.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
When add a ip (ip must to be specified see #3635) to a nic, in advanced zone with security groups, the network rules for the ip should be added on hypervisor. However it does not work in 4.13/master.
in agent.log it gives the following error
root@node32:~# /usr/share/cloudstack-common/scripts/vm/network/security_group.py network_rules_vmSecondaryIp --vmname i-14-54-VM --nicsecips 192.168.116.246 --action -A usage: security_group.py [-h] [--vmname VMNAME] [--vmip VMIP] [--vmip6 VMIP6] [--vmid VMID] [--vmmac VMMAC] [--vif VIF] [--sig SIG] [--seq SEQ] [--rules RULES] [--brname BRNAME] [--localbrname LOCALBRNAME] [--dhcpSvr DHCPSVR] [--hostIp HOSTIP] [--hostMacAddr HOSTMACADDR] [--nicsecips NICSECIPS] [--action ACTION] [--privnic PRIVNIC] [--isFirstNic] [--check] command security_group.py: error: argument --action: expected one argumentThe rules (ipset, iptables, ebtables) are added after this fix.