FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Increase DHCP lease time to infinite by andrijapanicsb · Pull Request #3662 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Increase DHCP lease time to infinite - #3662

Merged
DaanHoogland merged 2 commits into
masterfrom
andrijapanicsb-patch-3
Nov 5, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Increase DHCP lease time to infinite#3662
DaanHoogland merged 2 commits into
masterfrom
andrijapanicsb-patch-3

Conversation

andrijapanicsb commented Nov 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lease time set to effectively infinite (36000+ days) since we fully control VM lifecycle via CloudStack.
Infinite time helps avoid some edge cases which could cause DHCPNAK being sent to VMs since
(RHEL) system lose routes when they receive DHCPNAK.
When VM is expunged, its active lease and DHCP/DNS config is properly removed (#3627 and #3608) from related files in VR, so the infinite duration of lease does not cause any issues or garbage.
There will be soon a PR which also regenerates the /var/lib/misc/dnsmasq.leases (active lease DB file) in the new VR (when restarting network with cleanup), which will help around RHEL edge cases (described above) for the VMs who are already running in productions systems with 30d lease time.

Types of changes

  • Enhancement (improves an existing feature and functionality)

Increase lease time to infinite
93b9c7f 
Lease time set to effectively infinite (36000+ days) since we fully control VM lifecycle via CloudStack
Infinite time helps avoid some edge cases which could cause DHCPNAK being sent to VMs since
(RHEL) system lose routes when they receive DHCPNAK
When VM is expunged, it's active lease and DHCP/DNS config is properly removed from related files in VR.
desc fix
1d88351
andrijapanicsb changed the title Increase lease time to infinite Increase DHCP lease time to infinite Nov 3, 2019

andrijapanicsb commented Nov 3, 2019

Copy link
Copy Markdown
Contributor Author

CC @ustcweizhou (your username/name does NOT appear when requesting review...)

andrijapanicsb requested review from GabrielBrascher and PaulAngus and removed request for rafaelweingartner November 3, 2019 09:44
wido approved these changes Nov 4, 2019
View reviewed changes

wido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

yadvr approved these changes Nov 4, 2019
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Kindly test / kick tests.

ustcweizhou approved these changes Nov 4, 2019
View reviewed changes

ustcweizhou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code LGTM

andrijapanicsb commented Nov 4, 2019

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Nov 4, 2019

Copy link
Copy Markdown

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Nov 4, 2019

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-336

andrijapanicsb commented Nov 4, 2019

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Nov 4, 2019

Copy link
Copy Markdown

@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Nov 4, 2019

Copy link
Copy Markdown

Trillian test result (tid-444)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28251 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3662-t444-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

weizhouapache self-requested a review November 4, 2019 19:54
DaanHoogland merged commit d3f199f into master Nov 5, 2019
andrijapanicsb deleted the andrijapanicsb-patch-3 branch November 5, 2019 10:27
DaanHoogland pushed a commit that referenced this pull request Jan 3, 2020
Increase DHCP lease time to infinite (#3662)
2ffc0c5 
* Increase lease time to infinite

Lease time set to effectively infinite (36000+ days) since we fully control VM lifecycle via CloudStack
Infinite time helps avoid some edge cases which could cause DHCPNAK being sent to VMs since
(RHEL) system lose routes when they receive DHCPNAK
When VM is expunged, it's active lease and DHCP/DNS config is properly removed from related files in VR.

* desc fix
DaanHoogland added a commit that referenced this pull request Jan 7, 2020
Merge release branch 4.13 to master
6e19c17 
* 4.13:
  only update powerstate if sure it is the latest (#3743)
  ui: fix migrate host form no host popup (#3682)
  client: jetty session timeout set after server is started (#3658)
  Increase DHCP lease time to infinite (#3662)
andrijapanicsb mentioned this pull request Jan 13, 2020
Closed
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
Increase DHCP lease time to infinite (apache#3662)
1281aba 
* Increase lease time to infinite

Lease time set to effectively infinite (36000+ days) since we fully control VM lifecycle via CloudStack
Infinite time helps avoid some edge cases which could cause DHCPNAK being sent to VMs since
(RHEL) system lose routes when they receive DHCPNAK
When VM is expunged, it's active lease and DHCP/DNS config is properly removed from related files in VR.

* desc fix
NVShawn mentioned this pull request Jan 12, 2026
Merged
4 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
wido wido approved these changes
weizhouapache weizhouapache approved these changes
kiwiflyer Awaiting requested review from kiwiflyer
nvazquez Awaiting requested review from nvazquez
PaulAngus Awaiting requested review from PaulAngus
GabrielBrascher Awaiting requested review from GabrielBrascher
+1 more reviewer
ustcweizhou ustcweizhou approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL