FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ui: fix migrate host form no host popup by shwstppr · Pull Request #3682 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

ui: fix migrate host form no host popup - #3682

Merged
andrijapanicsb merged 1 commit into
apache:masterfrom
shapeblue:fix-ui-migrate-host-scroll
Nov 14, 2019
ConversationCommits (1)ChecksFiles changed
Merged

ui: fix migrate host form no host popup#3682
andrijapanicsb merged 1 commit into
apache:masterfrom
shapeblue:fix-ui-migrate-host-scroll

Conversation

shwstppr commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR changes behaviour for VM migrate host form where currently it shows a popup on scrolling to the end of the list saying No more hosts are available for migration. Popup has been removed to avoid confusion cleaner user experience.

Popup,

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

From UI
https://screencast-o-matic.com/watch/cqXIjtUDzF

ui: fix migrate host form no host popup
bf64406 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

andrijapanicsb commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Nov 13, 2019

Copy link
Copy Markdown

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Nov 13, 2019

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-353

andrijapanicsb commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

LGTM

Tested manually.

No need for any kind of test suite.

GabrielBrascher approved these changes Nov 14, 2019
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Makes sense removing that message.
Code LGTM.

yadvr added this to the 4.14.0.0 milestone Nov 14, 2019

yadvr commented Nov 14, 2019

Copy link
Copy Markdown
Member

This can be merged if someone can manually QA/test to confirm. cc @andrijapanicsb @borisstoyanov

andrijapanicsb commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

I have done that Rohit check my previous comment.

andrijapanicsb merged commit c8681f5 into apache:master Nov 14, 2019
DaanHoogland pushed a commit that referenced this pull request Jan 3, 2020
ui: fix migrate host form no host popup (#3682)
701f606 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
DaanHoogland added a commit that referenced this pull request Jan 7, 2020
Merge release branch 4.13 to master
6e19c17 
* 4.13:
  only update powerstate if sure it is the latest (#3743)
  ui: fix migrate host form no host popup (#3682)
  client: jetty session timeout set after server is started (#3658)
  Increase DHCP lease time to infinite (#3662)
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
ui: fix migrate host form no host popup (apache#3682)
e40e5e6 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
GabrielBrascher GabrielBrascher approved these changes
nvazquez Awaiting requested review from nvazquez
andrijapanicsb Awaiting requested review from andrijapanicsb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL