FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

maven quality tool plugins by DaanHoogland · Pull Request #3956 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

maven quality tool plugins - #3956

Merged
DaanHoogland merged 13 commits into
apache:masterfrom
shapeblue:owasp-dep-tjek
Mar 25, 2020
ConversationCommits (13)ChecksFiles changed
Merged

maven quality tool plugins#3956
DaanHoogland merged 13 commits into
apache:masterfrom
shapeblue:owasp-dep-tjek

Conversation

DaanHoogland commented Mar 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

owasp dependency checker and other tools during the site build phase to be able to add them to apache jenkins. inluding updates and cleanups.

Some version discrepencies arose so version upgrades are included and mvn dependency:tree | grep <this or that> | sort -u gave some that need handling:

com.fasterxml.jackson.core:jackson-core:jar:2.1.3:compile
com.fasterxml.jackson.core:jackson-core:jar:2.9.10:compile

com.google.code.findbugs:jsr305:jar:1.3.9:compile
com.google.code.findbugs:jsr305:jar:3.0.2:compile

com.google.http-client:google-http-client:jar:1.17.0-rc:compile
com.google.http-client:google-http-client:jar:1.20.0:compile

com.unboundid:unboundid-ldapsdk:jar:3.2.0:compile
com.unboundid:unboundid-ldapsdk:jar:4.0.14:test

commons-collections:commons-collections:jar:3.2.1:compile
commons-collections:commons-collections:jar:3.2.2:compile

commons-logging:commons-logging:jar:1.1.1:compile
commons-logging:commons-logging:jar:1.2:compile

javax.annotation:javax.annotation-api:jar:1.3.2:compile
# javax.annotation:javax.annotation-api:jar:1.3:compile

joda-time:joda-time:jar:2.10.5:compile
# joda-time:joda-time:jar:2.2:compile
# joda-time:joda-time:jar:2.8.1:compile
# joda-time:joda-time:jar:2.9.3:compile

org.slf4j:slf4j-api:jar:1.7.29:compile
org.slf4j:slf4j-log4j12:jar:1.7.29:compile

xerces:xercesImpl:jar:2.12.0:test
# xerces:xercesImpl:jar:2.8.0:compile
xml-apis:xml-apis-ext:jar:1.3.04:compile

# xml-apis:xml-apis:jar:1.0.b2:compile,test
# xml-apis:xml-apis:jar:1.4.01:test
xml-apis:xml-apis:jar:2.0.2:test,compile ???

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

DaanHoogland changed the title no default build phase for dep-check maven quality tool plugins Mar 10, 2020
DaanHoogland referenced this pull request Mar 10, 2020
Revert "CLOUDSTACK-10271 maven plugin for owasp dependency chec… (#3953)
016644d 
This reverts commit 2d63ed5. (PR #2446)
fails when network causes CVE DB not being able to be downloaded
DaanHoogland reopened this Mar 11, 2020
DaanHoogland reopened this Mar 11, 2020
DaanHoogland reopened this Mar 13, 2020
DaanHoogland reopened this Mar 13, 2020
DaanHoogland reopened this Mar 13, 2020

DaanHoogland commented Mar 13, 2020

Copy link
Copy Markdown
Contributor Author

@rhtyd @weizhouapache @GabrielBrascher finally apache builds gave a positive again on this maven update. can you approve?
cc @svenvogel @PaulAngus @AnyBody

DaanHoogland marked this pull request as ready for review March 13, 2020 16:28

DaanHoogland commented Mar 13, 2020

Copy link
Copy Markdown
Contributor Author

ping @weizhouapache @kiwiflyer @GabrielBrascher @rhtyd @nathanejohnson @andrijapanic-dont-use-this-one @svenvogel @wido this is ready for review.

nvazquez commented Mar 13, 2020

Copy link
Copy Markdown
Contributor

@DaanHoogland I got this error when building (with update dependecies flag)

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  15:24 min
[INFO] Finished at: 2020-03-13T14:11:21-03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project cloud-plugin-network-f5: Could not resolve dependencies for project org.apache.cloudstack:cloud-plugin-network-f5:jar:4.14.0.0-SNAPSHOT: Could not find artifact commons-discovery:commons-discovery:jar:1.0-dev in central (https://repo.maven.apache.org/maven2) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :cloud-plugin-network-f5

DaanHoogland commented Mar 14, 2020

Copy link
Copy Markdown
Contributor Author

@nvazquez I had been using -Dnonoss which has not been in use for ever and a day. You are right the dependency on f5 doesn't work.
testing further with mvn clean install -Dnoredist -P developer,systemvm, but it needs to work with mvn site -Dnoredist as well, will push if i get both to work.

nvazquez commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

@DaanHoogland I checked that the version 1.0-dev for the dependency commons-discovery is not present in the artifactory, so I changed the version to 0.5 (he last available in the repo: https://mvnrepository.com/artifact/commons-discovery/commons-discovery/0.5).

After changing that, I'm hitting a different error:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  16:42 min
[INFO] Finished at: 2020-03-14T20:48:46-03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project cloud-plugin-outofbandmanagement-driver-nested-cloudstack: Could not resolve dependencies for project org.apache.cloudstack:cloud-plugin-outofbandmanagement-driver-nested-cloudstack:jar:4.14.0.0-SNAPSHOT: Failed to collect dependencies at org.apache.cloudstack:cloud-server:jar:clover:4.14.0.0-SNAPSHOT -> org.apache.cloudstack:cloud-framework-jobs:jar:4.14.0.0-SNAPSHOT -> org.apache.cloudstack:cloud-framework-events:jar:4.14.0.0-SNAPSHOT -> com.google.guava:guava:jar:28.2-jre -> org.checkerframework:checker-qual:jar:2.10.0: class java.util.HashMap$Node cannot be cast to class java.util.HashMap$TreeNode (java.util.HashMap$Node and java.util.HashMap$TreeNode are in module java.base of loader 'bootstrap') -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :cloud-plugin-outofbandmanagement-driver-nested-cloudstack

BTW: I'm compiling with:

mvn clean install -Dnoredist -P developer,systemvm -DskipTests -U

DaanHoogland commented Mar 16, 2020

Copy link
Copy Markdown
Contributor Author

very frustrating, I'm hitting a different one:

[ERROR] Failed to execute goal on project cloud-vmware-base: Could not resolve dependencies for project org.apache.cloudstack:cloud-vmware-base:jar:4.14.0.0-SNAPSHOT: Failure to find com.sun.xml.ws:jaxws-ri:pom:2.6 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1]

nvazquez commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

@DaanHoogland can you try adding -U to force updating the dependencies?

DaanHoogland commented Mar 16, 2020

Copy link
Copy Markdown
Contributor Author

mvn clean install -Dnoredist -P developer,systemvm -U tried, it doesn't complete with above error. Unfortunately having a compiled system is more important than having good analysis output so no go for this, for now.

DaanHoogland commented Mar 23, 2020

Copy link
Copy Markdown
Contributor Author

@svenvogel why would you put a label security on this PR?

DaanHoogland commented Mar 24, 2020

Copy link
Copy Markdown
Contributor Author

ok, builds now on

@rhtyd @weizhouapache @GabrielBrascher can you approve?

yadvr commented Mar 24, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Mar 24, 2020

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

GabrielBrascher approved these changes Mar 24, 2020
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM based on code review and build success.

Environment:
Apache Maven 3.3.9
Java version: 11.0.5 (java-11-openjdk-amd64)
OS: Ubuntu 16.04, version: "4.4.0-173-generic"

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:40 min
[INFO] Finished at: 2020-03-24T11:20:58-03:00
[INFO] Final Memory: 202M/694M
[INFO] ------------------------------------------------------------------------

blueorangutan commented Mar 24, 2020

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1082

DaanHoogland reopened this Mar 24, 2020
DaanHoogland merged commit 9b74a3a into apache:master Mar 25, 2020
DaanHoogland deleted the owasp-dep-tjek branch March 25, 2020 10:56

blueorangutan commented Mar 25, 2020

Copy link
Copy Markdown

Trillian test result (tid-1302)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28513 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3956-t1302-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_add_delete_kubernetes_supported_version Error 0.34 test_kubernetes_supported_versions.py

nvazquez mentioned this pull request Apr 5, 2020
Merged
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GabrielBrascher GabrielBrascher approved these changes
yadvr Awaiting requested review from yadvr
weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL