FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improvement on build time and new quality profile by nvazquez · Pull Request #4014 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Improvement on build time and new quality profile - #4014

Merged
DaanHoogland merged 2 commits into
apache:masterfrom
shapeblue:mvntweaks
Apr 7, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Improvement on build time and new quality profile#4014
DaanHoogland merged 2 commits into
apache:masterfrom
shapeblue:mvntweaks

Conversation

nvazquez commented Apr 5, 2020

Copy link
Copy Markdown
Contributor

Description

Since PR #3956 has been merged the build time has increased drastically due to the quality tools added.

This PR simply removes these tools from the default build execution and adds a new profile with name: quality to enable these tools.

To enable this new profile, simply append: -P quality to the maven build command

As a result, the default build time increases significantly, as shown in the 'How has this been tested' section

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Tested on Ubuntu 19.10 laptop, 8x1.8Ghz CPU - 16GB RAM
openjdk version "11.0.6" 2020-01-14
Apache Maven 3.6.1

Default build:

$ mvn clean install -Dnoredist -P developer,systemvm -DskipTests -T4

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:21 min (Wall Clock)
[INFO] Finished at: 2020-04-05T01:16:18-03:00
[INFO] ------------------------------------------------------------------------

Enabling quality tools (x2+ slower):

mvn clean install -Dnoredist -P developer,systemvm,quality -U -DskipTests -T4

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  16:25 min (Wall Clock)
[INFO] Finished at: 2020-04-05T01:42:07-03:00
[INFO] ------------------------------------------------------------------------

nvazquez added this to the 4.14.0.0 milestone Apr 5, 2020

nvazquez commented Apr 5, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Apr 5, 2020

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Apr 5, 2020

Copy link
Copy Markdown

Packaging result: ✖centos7 ✖debian. JID-1126

nvazquez commented Apr 5, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Apr 5, 2020

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Apr 5, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1127

nvazquez commented Apr 5, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Apr 5, 2020

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Apr 5, 2020

Copy link
Copy Markdown

Trillian test result (tid-1360)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42754 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4014-t1360-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_deploy_and_upgrade_kubernetes_cluster Failure 640.29 test_kubernetes_clusters.py

andrijapanicsb removed their request for review April 6, 2020 10:09

andrijapanicsb commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

@shwstppr could you kindly see what is the issue with this Test - it was failing in some other PRs in master - we need this fix, please.

shwstppr commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

@andrijapanicsb running test manually to check for any issue with the test

nvazquez closed this Apr 6, 2020
nvazquez reopened this Apr 6, 2020

DaanHoogland commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

looks good, let's await the jenkins results and not forget to change the jovb according to thios PR afterwards.

nvazquez commented Apr 6, 2020

Copy link
Copy Markdown
Contributor Author

@DaanHoogland job finished: https://builds.apache.org/view/All/job/cloudstack-pr-analysis/10284/

andrijapanicsb commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

Anyone OK with this one? I can't really comment on anything.

GabrielBrascher approved these changes Apr 6, 2020
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code LGTM

yadvr approved these changes Apr 7, 2020
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Didn't test, Daan's review needed. Lgtm otherwise.

DaanHoogland commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

I ok'd it already and did collaborate with @nvazquez testing it with builds.apache.org
merging

DaanHoogland merged commit 3d4b9af into apache:master Apr 7, 2020
DaanHoogland deleted the mvntweaks branch April 7, 2020 08:54

DaanHoogland commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

@nvazquez please check if the one '-P quality' that I added in builds.apache.org is enough!? tnx

nvazquez commented Apr 7, 2020

Copy link
Copy Markdown
Contributor Author

Yes @DaanHoogland thanks

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
DaanHoogland DaanHoogland approved these changes
GabrielBrascher GabrielBrascher approved these changes

Assignees

No one assigned

Labels

component:build type:improvement

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL