FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove use of blacklist/whitelist terms by PaulAngus · Pull Request #4135 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Remove use of blacklist/whitelist terms - #4135

Closed
PaulAngus wants to merge 8 commits into
apache:masterfrom
shapeblue:neutralising
ConversationCommits (8)ChecksFiles changed
Closed

Remove use of blacklist/whitelist terms#4135
PaulAngus wants to merge 8 commits into
apache:masterfrom
shapeblue:neutralising

Conversation

PaulAngus commented Jun 8, 2020

Copy link
Copy Markdown
Member

Description

This PR removes the terms blacklist and whitelist in favour of allow list and deny list.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

PaulAngus commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Jun 8, 2020

Copy link
Copy Markdown

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland reviewed Jun 8, 2020
View reviewed changes
Comment thread api/src/main/java/org/apache/cloudstack/query/QueryService.java Outdated
static final ConfigKey<String> UserVMBlacklistedDetails = new ConfigKey<String>("Advanced", String.class,
"user.vm.blacklisted.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",
static final ConfigKey<String> UserVMDenyListedDetails = new ConfigKey<String>("Advanced", String.class,
"user.vm.DenyListed.details", "rootdisksize, cpuOvercommitRatio, memoryOvercommitRatio, Message.ReservedCapacityFreed.Flag",

DaanHoogland Jun 8, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

not sure if this is an issue but naming convention fro settings is all lower case.

PaulAngus Jun 8, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've fixed incorrect case change - sloppy C&P

blueorangutan commented Jun 8, 2020

Copy link
Copy Markdown

Packaging result: ✖centos7 ✖debian. JID-1314

borisstoyanov commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

@blueorangutan help

blueorangutan commented Jun 8, 2020

Copy link
Copy Markdown

@borisstoyanov I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the test/integration directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

borisstoyanov commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Jun 8, 2020

Copy link
Copy Markdown

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jun 8, 2020

Copy link
Copy Markdown

Packaging result: ✖centos7 ✖debian. JID-1318

PaulAngus commented Jun 8, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Jun 8, 2020

Copy link
Copy Markdown

@PaulAngus a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jun 8, 2020

Copy link
Copy Markdown

Packaging result: ✖centos7 ✖debian. JID-1319

GabrielBrascher approved these changes Jul 1, 2020
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

GabrielBrascher commented Jul 1, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Jul 1, 2020

Copy link
Copy Markdown

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jul 1, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1502

borisstoyanov approved these changes Jul 3, 2020
View reviewed changes

borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, based on code

DaanHoogland requested changes Sep 18, 2020
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@PaulAngus are you addressing the upgrade scripts? (/me only half volunteering)

Comment thread engine/schema/src/main/resources/META-INF/db/schema-410to420.sql Resolved
Comment thread ...mic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java Resolved
Comment thread ...atic-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java Resolved
Comment thread plugins/database/mysql-ha/src/main/java/com/cloud/utils/db/StaticStrategy.java Resolved
Comment thread server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java Resolved
Comment thread server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java Resolved
Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Resolved
Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Resolved
Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Resolved
yadvr mentioned this pull request Oct 27, 2020
Merged

yadvr commented Oct 28, 2020

Copy link
Copy Markdown
Member

@DaanHoogland Paul may need assistance, can ask for his advice and address review issues on his behalf as well as fix the issue renaming via the upgrade path.

DaanHoogland commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

@DaanHoogland Paul may need assistance, can ask for his advice and address review issues on his behalf as well as fix the issue renaming via the upgrade path.

is this you volunteering, @rhtyd ?

shwstppr mentioned this pull request Feb 1, 2021
Merged
3 of 12 tasks
DaanHoogland added this to the 4.16.0.0 milestone Feb 1, 2021

sureshanaparti commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Apr 9, 2021

Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Apr 9, 2021

Copy link
Copy Markdown

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 373

DaanHoogland self-requested a review April 9, 2021 09:21

sureshanaparti commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Apr 9, 2021

Copy link
Copy Markdown

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Apr 9, 2021

Copy link
Copy Markdown

Trillian test result (tid-396)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44246 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4135-t396-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_migrate_VM_and_root_volume Error 69.19 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 53.14 test_vm_life_cycle.py

sureshanaparti marked this pull request as draft April 15, 2021 08:34

yadvr commented Apr 26, 2021

Copy link
Copy Markdown
Member

Further changes moved here #4922 closing this, #4922 will continue the effort.

yadvr closed this Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr left review comments
shwstppr shwstppr left review comments
DaanHoogland DaanHoogland approved these changes
GabrielBrascher GabrielBrascher approved these changes
borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

status:waiting-for-author type:cleanup

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL