FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

remove blacklist and whitelist phrases by PaulAngus · Pull Request #137 · apache/cloudstack-documentation · GitHub

  1. apache
  2. cloudstack-documentation

Repository navigation

remove blacklist and whitelist phrases - #137

Merged
DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:review_phrasing
Sep 18, 2020
ConversationCommits (1)ChecksFiles changed
Merged

remove blacklist and whitelist phrases#137
DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:review_phrasing

Conversation

PaulAngus commented Jun 8, 2020

Copy link
Copy Markdown
Member

small alterations to remove the phrases blacklist and whitelist

DaanHoogland merged commit 13e1f5d into apache:master Sep 18, 2020
DaanHoogland deleted the review_phrasing branch September 18, 2020 08:40
DaanHoogland added a commit that referenced this pull request Sep 18, 2020
Revert "remove blacklist and whitelist phrases (#137)"
21f443d 
This reverts commit 13e1f5d.
DaanHoogland mentioned this pull request Sep 18, 2020
Merged
yadvr pushed a commit that referenced this pull request Sep 18, 2020
Revert "remove blacklist and whitelist phrases (#137)" (#154)
0a4edbe 
This reverts commit 13e1f5d.

yadvr commented Sep 18, 2020

Copy link
Copy Markdown
Member

@DaanHoogland @PaulAngus you may need to re-open the PR and merge only after the upstream PR to apache/cloudstack is merged with a DB upgrade path too

DaanHoogland restored the review_phrasing branch September 18, 2020 09:21

PaulAngus commented Oct 26, 2020

Copy link
Copy Markdown
Member Author

theres a closed pull for an empty DB path (apache/cloudstack#4092) do you happen to know if/what the PR for one with contents in ? (i can't find one)

DaanHoogland commented Oct 26, 2020

Copy link
Copy Markdown
Contributor

I don't think I understand your question @PaulAngus . Are you asking whether any PR added DB changes to the file?
if so:

cfbb4ff3dd5a53f55040d3345b96bc7e97964eb2 - schema: change upgrade path to 4.14 (from 4.13) and intensify check (#4331)(Pearl Dsilva)
d949302d0f6805b895307f68a561762bcbc87aff - packaging: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support (#4068)(davidjumani)
c578004fe5f049684830d4323422dc3953481ac7 - projects: Role based users in Projects (#4128)(Pearl Dsilva)
64c69389db7fbf45784baef28f3f5e8bcd084ff9 - db: VMware Guest OS Mappings fix (#4196)(Andrija Panic)
5040283db9744175402b53ba9a6c701b9d8e3436 - server: Dynamic roles improvements. Add-on functionality below. (#4071)(sureshanaparti)
d0d346524bd04a8b1691c1a0b7fe36ea23d4311c - schema: add empty DB upgrade path from 4.14.0.0 to 4.15.0.0 (#4092)(Abhishek Kumar)

yadvr commented Oct 27, 2020

Copy link
Copy Markdown
Member

@PaulAngus the backend PR for this doc change hasn't been merged, so this was reverted and Daan re-opened a PR with the changes - #155

yadvr commented Oct 27, 2020

Copy link
Copy Markdown
Member

The backend PR for this doc PR is - apache/cloudstack#4135

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GabrielBrascher GabrielBrascher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL