FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Provide cleanup option to force deleting a project by ravening · Pull Request #4453 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Provide cleanup option to force deleting a project - #4453

Closed
ravening wants to merge 4 commits into
apache:masterfrom
ravening:cleanup-project
ConversationCommits (4)ChecksFiles changed
Closed

Provide cleanup option to force deleting a project#4453
ravening wants to merge 4 commits into
apache:masterfrom
ravening:cleanup-project

Conversation

ravening commented Nov 6, 2020

Copy link
Copy Markdown
Member

Description

Provide an option to user which when selected
deletes all the resources in the project.
If not selected then the project is not deleted if
all the resources are not yet cleaned up

Types of changes

  • Enhancement (improves an existing feature and functionality)

Screenshots (if appropriate):


]

How Has This Been Tested?

ravening mentioned this pull request Nov 6, 2020
Open
DaanHoogland added this to the 4.16.0.0 milestone Nov 6, 2020

DaanHoogland commented Nov 17, 2020

Copy link
Copy Markdown
Contributor

code looks ok, but needs tests and primate UI

ravening commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

code looks ok, but needs tests and primate UI

@DaanHoogland I have already created pr for ui changes

davidjumani approved these changes Nov 23, 2020
View reviewed changes

davidjumani left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Unable to delete a project if it has resources but can do so by passing cleanup as true
There could be other checks for resources such as ssh keys, etc but the basics are covered

Allow users to update volume name
81c5afd 
Provide an api support to update volume name by all users
Can be done both through api and UI

weizhouapache commented Jan 25, 2021

Copy link
Copy Markdown
Member

@ravening can you resolve the conflicts, and make primate ui change ?

Allow users to update volume name
efc39da 
Provide an api support to update volume name by all users
Can be done both through api and UI
Merge branch 'master' of https://github.com/ravening/cloudstack
db88887
Provide an option to user which when selected
ff989e3 
deletes all the resources in the project.
If not selected then the project is not deleted if
all the resources are not yet cleaned up
ravening closed this Jan 26, 2021
ravening deleted the cleanup-project branch January 26, 2021 11:14

ravening commented Jan 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

@weizhouapache created new pr #4617

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

davidjumani davidjumani approved these changes
weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:management-server type:enhancement

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL