FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Provide option to force delete the project by ravening · Pull Request #848 · apache/cloudstack-primate · GitHub

This repository was archived by the owner on Jan 20, 2021. It is now read-only.
  1. apache
  2. cloudstack-primate

Repository navigation

Provide option to force delete the project - #848

Open
ravening wants to merge 2 commits into
apache:masterfrom
ravening:cleanup-project
ConversationCommits (2)ChecksFiles changed
Open

Provide option to force delete the project#848
ravening wants to merge 2 commits into
apache:masterfrom
ravening:cleanup-project

Conversation

ravening commented Nov 6, 2020

Copy link
Copy Markdown
Member

Provide a cleanup flag so that the project will
be deleted only when there are no resources left
in the project. If users click on delete project
by mistake then everything is deleted.

NOTE: Backend change is in apache/cloudstack#4453

GabrielBrascher approved these changes Nov 7, 2020
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code LGTM

davidjumani commented Nov 11, 2020

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Nov 11, 2020

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

yadvr added this to the 1.1 milestone Nov 11, 2020

davidjumani commented Nov 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@ravening Could you add a check whether the parameter exists for the API, similar to https://github.com/apache/cloudstack-primate/blob/master/src/config/section/compute.js#L112
It breaks on versions without the cleanup parameter

blueorangutan commented Nov 11, 2020

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/848 (JID-3660)

ravening commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

@ravening Could you add a check whether the parameter exists for the API, similar to https://github.com/apache/cloudstack-primate/blob/master/src/config/section/compute.js#L112
It breaks on versions without the cleanup parameter

@davidjumani I can add that but this feature is supported 4.15 onwards only. I dont think there will be other version where this is supported

Provide option to force delete the project
e82335b 
Provide a cleanup flag so that the project will
be deleted only when there are no resources left
in the project. If users click on delete project
by mistake then everything is deleted.

ravening commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

@ravening Could you add a check whether the parameter exists for the API, similar to https://github.com/apache/cloudstack-primate/blob/master/src/config/section/compute.js#L112
It breaks on versions without the cleanup parameter

@davidjumani I can add that but this feature is supported 4.15 onwards only. I dont think there will be other version where this is supported

@davidjumani made changes

davidjumani commented Nov 20, 2020

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Nov 20, 2020

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented Nov 20, 2020

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/848 (JID-3681)

davidjumani approved these changes Nov 20, 2020
View reviewed changes

davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

davidjumani added the feature New Feature label Dec 3, 2020
ravening mentioned this pull request Jan 26, 2021
Merged
3 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
GabrielBrascher GabrielBrascher approved these changes
davidjumani davidjumani approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature New Feature

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL