FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding cpuallocated percentage and value to host and hostsformigrationresponse by davidjumani · Pull Request #4499 · apache/cloudstack · GitHub

/ cloudstack Public

Adding cpuallocated percentage and value to host and hostsformigrationresponse - #4499

Merged
yadvr merged 2 commits into
apache:4.14from
shapeblue:fix-host-cpu
Dec 1, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Adding cpuallocated percentage and value to host and hostsformigrationresponse#4499
yadvr merged 2 commits into
apache:4.14from
shapeblue:fix-host-cpu

Conversation

davidjumani commented Nov 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #4488

Deprecates cpuallocated and adds a new field cpuallocatedwithoverprovisoning which considers overprovisioning.
Also adds cpuallocatedpercentage and cpuallocatedvalue to provide clearer metrics

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

(localhost) 🐱 > list hosts filter=cpuallocatedvalue,cpuallocatedpercentage,cpuallocatedwithoverprovisioning,cpuallocated, type=Routing clusterid=56d84816-7594-49ba-99fd-d5c647fb4890
{
  "count": 2,
  "host": [
    {
      "cpuallocated": "1.56%",
      "cpuallocatedpercentage": "1.56%",
      "cpuallocatedvalue": 500,
      "cpuallocatedwithoverprovisioning": "0.78%"
    },
    {
      "cpuallocated": "6.25%",
      "cpuallocatedpercentage": "6.25%",
      "cpuallocatedvalue": 2000,
      "cpuallocatedwithoverprovisioning": "3.12%"
    }
  ]
}


(localhost) 🐱 > find hostsformigration virtualmachineid=a4dfcf94-76b5-41fc-9ceb-424f0eff5427  filter=cpuallocatedvalue,cpuallocatedpercentage,cpuallocatedwithoverprovisioning,cpuallocated, type=Routing
{
  "count": 2,
  "host": [
    {
      "cpuallocated": "1.56%",
      "cpuallocatedpercentage": "1.56%",
      "cpuallocatedvalue": 500,
      "cpuallocatedwithoverprovisioning": "0.78%"
    }
  ]
}

davidjumani commented Nov 24, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

davidjumani added this to the 4.14.1.0 milestone Nov 24, 2020
davidjumani changed the base branch from master to 4.14 November 24, 2020 05:12

blueorangutan commented Nov 24, 2020

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Nov 24, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2426

davidjumani commented Nov 24, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Nov 24, 2020

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Nov 24, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2429

yadvr requested a review from weizhouapache November 24, 2020 11:09
davidjumani changed the title Adding cpuallocatedwithoverprovisoning to host and hostsformigrationresponse Adding cpuallocated percentage and value to host and hostsformigrationresponse Nov 25, 2020

yadvr commented Nov 27, 2020

Copy link
Copy Markdown
Member

@blueorangutan test

blueorangutan commented Nov 27, 2020

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Nov 27, 2020

Copy link
Copy Markdown

Trillian test result (tid-3274)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31320 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4499-t3274-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

yadvr merged commit afebfd5 into apache:4.14 Dec 1, 2020
qrry pushed a commit to qrry/cloudstack that referenced this pull request Dec 4, 2020
Merge branch 'master' into dev
71956b7 
* master: (25 commits)
  integration test: skip vlan of public ip range in get_free_vlan
  vpc vr: plugin nics by this order: public/private/guest
  vpc vr: fix Conflicting device id on private gw nic
  Adding zone name to physicalnetworkresponse (apache#4510)
  Disallowing udp for lb rules for haproxy (apache#4501)
  Make global setting non-dynamic (apache#4505)
  Adding cpuallocated percentage and value to host and hostsformigrationresponse (apache#4499)
  kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs (apache#4496)
  fix failures with test_multiple_nic_support.py (apache#4495)
  Fix hosts for migration count (apache#4500)
  sql: Fix Zones are returned in a random order (apache#3934) (apache#4494)
  integration test: update steps
  integration test: add private gateway in test
  integration test: verify public nics state
  bugfix apache#9 vpc vr: Add PREROUTING rule for vm with static nat to multiple private gateways
  bugfix apache#8 vpc: add rule for traffic between vm and private gateway
  bugfix apache#7 vpc vr: allow servers in private gateway to reach internet via the VPC VR if it is gateway
  bugfix apache#6 vpc vr: Add iptables rules for ACL of private gateway
  Revert "Fix Policy Based Routing for private gateway static routes (apache#3604)"
  Revert "Add private gateway IP to router initialization config"
  ...
yadvr mentioned this pull request Mar 6, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
DaanHoogland DaanHoogland approved these changes
weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

type:enhancement

Projects

None yet

Milestone

4.14.1.0

Development

Successfully merging this pull request may close these issues.

add cpu percentage and value

4 participants

Back | FazBrowse Home | New Git URL