FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding zone name to physicalnetworkresponse by davidjumani · Pull Request #4510 · apache/cloudstack · GitHub

/ cloudstack Public

Adding zone name to physicalnetworkresponse - #4510

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:add-zone-phy-net
Dec 2, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Adding zone name to physicalnetworkresponse#4510
yadvr merged 1 commit into
apache:masterfrom
shapeblue:add-zone-phy-net

Conversation

davidjumani commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

Description

Adding zone name to physicalnetworkresponse which looks better on the UI

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Before :

After :

How Has This Been Tested?

(localhost) 🐱 > list physicalnetworks 
{
  "count": 1,
  "physicalnetwork": [
    {
      "broadcastdomainrange": "ZONE",
      "id": "580b516c-f1fa-4fc4-949c-42381a394287",
      "isolationmethods": "VLAN",
      "name": "Sandbox-pnet",
      "state": "Enabled",
      "vlan": "100-200",
      "zoneid": "ee54cb21-c2e2-4757-bb4a-a2e16a4c2516",
      "zonename": "Sandbox-simulator"
    }
  ]
}

davidjumani commented Dec 1, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Dec 1, 2020

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Dec 1, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2451

yadvr added this to the 4.15.0.0 milestone Dec 1, 2020

yadvr commented Dec 1, 2020

Copy link
Copy Markdown
Member

@blueorangutan test

blueorangutan commented Dec 1, 2020

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Dec 1, 2020

Copy link
Copy Markdown

Trillian test result (tid-3294)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31636 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4510-t3294-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

GabrielBrascher approved these changes Dec 1, 2020
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

davidjumani mentioned this pull request Dec 1, 2020
Merged
yadvr merged commit 93ff156 into apache:master Dec 2, 2020
qrry pushed a commit to qrry/cloudstack that referenced this pull request Dec 4, 2020
Merge branch 'master' into dev
71956b7 
* master: (25 commits)
  integration test: skip vlan of public ip range in get_free_vlan
  vpc vr: plugin nics by this order: public/private/guest
  vpc vr: fix Conflicting device id on private gw nic
  Adding zone name to physicalnetworkresponse (apache#4510)
  Disallowing udp for lb rules for haproxy (apache#4501)
  Make global setting non-dynamic (apache#4505)
  Adding cpuallocated percentage and value to host and hostsformigrationresponse (apache#4499)
  kvm: fix router.aggregation.command.each.timeout is reset to 600 when update other kvm configs (apache#4496)
  fix failures with test_multiple_nic_support.py (apache#4495)
  Fix hosts for migration count (apache#4500)
  sql: Fix Zones are returned in a random order (apache#3934) (apache#4494)
  integration test: update steps
  integration test: add private gateway in test
  integration test: verify public nics state
  bugfix apache#9 vpc vr: Add PREROUTING rule for vm with static nat to multiple private gateways
  bugfix apache#8 vpc: add rule for traffic between vm and private gateway
  bugfix apache#7 vpc vr: allow servers in private gateway to reach internet via the VPC VR if it is gateway
  bugfix apache#6 vpc vr: Add iptables rules for ACL of private gateway
  Revert "Fix Policy Based Routing for private gateway static routes (apache#3604)"
  Revert "Add private gateway IP to router initialization config"
  ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
GabrielBrascher GabrielBrascher approved these changes
DaanHoogland Awaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

type:enhancement

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL