FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: Submit the form when press CTRL + ENTER by utchoang · Pull Request #4766 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

UI: Submit the form when press CTRL + ENTER - #4766

Merged
nvazquez merged 30 commits into
apache:mainfrom
utchoang:feature/enter-submit-form
Jul 26, 2021
ConversationCommits (30)ChecksFiles changed
Merged

UI: Submit the form when press CTRL + ENTER#4766
nvazquez merged 30 commits into
apache:mainfrom
utchoang:feature/enter-submit-form

Conversation

utchoang commented Mar 8, 2021 •
edited
Loading

Copy link
Copy Markdown

Description

This PR for fixes submit the form when pressing Enter

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

utchoang mentioned this pull request Mar 8, 2021
Merged
3 of 12 tasks

utchoang commented Mar 8, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Mar 8, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 8, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (JID-3855)

utchoang marked this pull request as draft March 9, 2021 01:56
utchoang marked this pull request as ready for review March 11, 2021 09:03
utchoang requested review from shwstppr and yadvr March 15, 2021 06:07
utchoang mentioned this pull request Mar 16, 2021
Closed
yadvr added this to the 4.15.1.0 milestone Mar 17, 2021

yadvr commented Mar 18, 2021

Copy link
Copy Markdown
Member

Could this break anything? (for example in any input that is textarea of multi-line) cc @shwstppr @Pearl1594 @borisstoyanov @vladimirpetrov @andrijapanicsb

utchoang commented Mar 18, 2021

Copy link
Copy Markdown
Author

@rhtyd Yes, currently for textarea, selectbox focus the press enter will not submit the form

andrijapanicsb commented Mar 18, 2021

Copy link
Copy Markdown
Contributor

Industry practice, from what I've seen is to use CTRL + ENTER to submit a form (i.e. in gmail to send email, in Jira to send comment, in Outlook to send email, etc)

simple ENTER sounds a bit "dangerous"

andrijapanicsb commented Mar 18, 2021

Copy link
Copy Markdown
Contributor

and GitHub also uses CTRL + ENTER to send THIS COMMENT :)

utchoang changed the title UI: Submit the form when press enter UI: Submit the form when press CTRL + ENTER Mar 19, 2021
apache deleted a comment from blueorangutan Mar 19, 2021
apache deleted a comment from blueorangutan Mar 19, 2021

utchoang commented Mar 19, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Mar 19, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

blueorangutan commented Mar 19, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-40)

utchoang commented Mar 19, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Mar 19, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

utchoang commented Jul 26, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Jul 26, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Jul 26, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-423)

utchoang commented Jul 26, 2021

Copy link
Copy Markdown
Author

@davidjumani can you check it again? Thanks.

utchoang commented Jul 26, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Jul 26, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Jul 26, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-424)

davidjumani reviewed Jul 26, 2021
View reviewed changes
Comment thread ui/src/utils/directives.js Resolved

davidjumani commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Jul 26, 2021

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

davidjumani commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

@utchoang Facing the issue mentioned in #4766 (comment) again, perhaps something changed in a6c9086#diff-dc23cc72876b181f8c378a3aae62dd04c7e3dcddea70113f45ac8acd741ceca7 broke it ?

blueorangutan commented Jul 26, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-425)

utchoang commented Jul 26, 2021

Copy link
Copy Markdown
Author

@davidjumani

@utchoang Facing the issue mentioned in #4766 (comment) again, perhaps something changed in a6c9086#diff-dc23cc72876b181f8c378a3aae62dd04c7e3dcddea70113f45ac8acd741ceca7 broke it ?

sorry I forgot this on Firefox, I'll fix it now

davidjumani commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Jul 26, 2021

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Jul 26, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4766 (SL-JID-426)

davidjumani approved these changes Jul 26, 2021
View reviewed changes

davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Thanks @utchoang

nvazquez approved these changes Jul 26, 2021
View reviewed changes

nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nvazquez merged commit 8efc3ea into apache:main Jul 26, 2021
utchoang deleted the feature/enter-submit-form branch July 27, 2021 00:34

davidjumani commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

@utchoang I'm getting these errors at times (now while trying to add a firewall rule) by pressing control-enter. Can you please check

utchoang mentioned this pull request Aug 10, 2021
Merged
3 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nvazquez nvazquez approved these changes
davidjumani davidjumani approved these changes
Pearl1594 Pearl1594 approved these changes
yadvr Awaiting requested review from yadvr
shwstppr Awaiting requested review from shwstppr

Assignees

davidjumani

Pearl1594

Labels

component:UI type:new-feature

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL