FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: Network offering selection - Show display text instead of the name by utchoang · Pull Request #4831 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

UI: Network offering selection - Show display text instead of the name - #4831

Merged
yadvr merged 1 commit into
apache:4.15from
utchoang:feature/networkoffering-show-displaytext
Mar 18, 2021
ConversationCommits (1)ChecksFiles changed
Merged

UI: Network offering selection - Show display text instead of the name#4831
yadvr merged 1 commit into
apache:4.15from
utchoang:feature/networkoffering-show-displaytext

Conversation

utchoang commented Mar 17, 2021 •
edited
Loading

Copy link
Copy Markdown

Description

Related apache/cloudstack-primate#844
This PR to fix show display text instead of the name

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

utchoang mentioned this pull request Mar 17, 2021
Closed

utchoang commented Mar 17, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Mar 17, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

blueorangutan commented Mar 17, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4831 (SL-JID-33)

utchoang requested review from shwstppr and yadvr March 17, 2021 03:29
yadvr added this to the 4.15.1.0 milestone Mar 17, 2021
yadvr approved these changes Mar 17, 2021
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM we need someone to manually check the create network cases (from deploy VM form and network -> add network)

yadvr commented Mar 17, 2021

Copy link
Copy Markdown
Member

@shwstppr was a manual test done?

shwstppr commented Mar 18, 2021

Copy link
Copy Markdown
Contributor

@rhtyd yes, tested network forms from Networks section and zone's traffic type tab

yadvr merged commit d105d6a into apache:4.15 Mar 18, 2021
utchoang deleted the feature/networkoffering-show-displaytext branch March 23, 2021 03:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
shwstppr shwstppr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL