Repository navigation
Show display text instead of name - #844
ravening wants to merge 1 commit into
Conversation
Sorry, something went wrong.
For network offerings, show meaningful display text instead of short names which is not much descriptive
yadvr
left a comment
There was a problem hiding this comment.
LGTM, but we need to check how legacy UI shows the name (name vs displayname vs description)
Sorry, something went wrong.
@rhtyd legacy ui displays name but it wont make sense just by looking at the name. displaytext gives more info about the offering |
Sorry, something went wrong.
GabrielBrascher
left a comment
There was a problem hiding this comment.
LGTM
+1 on using display name as a user-friendly identification.
To be honest, sometimes I don't see much value in the displayname field; I think that this is indeed how it should be used.
Sorry, something went wrong.
|
@ravening we may need to build consensus then, we largely want Primate 1.0/GA to be backwards compatible wrt UX, so changing how a field is displayed may break several people's env who were used to seeing the name. (To satisfy everyone - one solution could be showing the name and in parenthesis the displayname). @blueorangutan package |
Sorry, something went wrong.
|
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
Sorry, something went wrong.
|
For now, moved to 1.1 as this is not a blocker or critical issue. |
Sorry, something went wrong.
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
Sorry, something went wrong.
| <a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex"> | ||
| {{ opt.name || opt.description }} | ||
| {{ opt.displaytext || opt.description }} | ||
| </a-select-option> |
There was a problem hiding this comment.
@ravening can this be: opt.displaytext | opt.name | ... to cover for the case if/when displaytext is empty?
Sorry, something went wrong.
| @change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }"> | ||
| <a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex"> | ||
| {{ opt.name || opt.description }} | ||
| {{ opt.displaytext || opt.description }} |
There was a problem hiding this comment.
@ravening can this be: opt.displaytext | opt.name | ... to cover for the case if/when displaytext is empty?
Sorry, something went wrong.
| @change="val => { this.handleNetworkOfferingChange(this.networkOfferings[val]) }"> | ||
| <a-select-option v-for="(opt, optIndex) in this.networkOfferings" :key="optIndex"> | ||
| {{ opt.name || opt.description }} | ||
| {{ opt.displaytext || opt.description }} |
There was a problem hiding this comment.
@ravening can this be: opt.displaytext | opt.name | ... to cover for the case if/when displaytext is empty?
Sorry, something went wrong.
While creating networks, for network offerings, show meaningful display text
instead of short names which is not much descriptive