FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ui: fix create account/user with saml by shwstppr · Pull Request #5481 · apache/cloudstack · GitHub

/ cloudstack Public

ui: fix create account/user with saml - #5481

Merged
yadvr merged 5 commits into
apache:mainfrom
shapeblue:fix-ui-create-user-saml
Sep 21, 2021
ConversationCommits (5)ChecksFiles changed
Merged

ui: fix create account/user with saml#5481
yadvr merged 5 commits into
apache:mainfrom
shapeblue:fix-ui-create-user-saml

Conversation

shwstppr commented Sep 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #5477
Fixes #5478

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before change:

After change:

How Has This Been Tested?

ui: fix create user with saml
32243b1 
Fixes apache#5478

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr commented Sep 21, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

yadvr added this to the 4.16.0.0 milestone Sep 21, 2021

yadvr commented Sep 21, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-673)

yadvr commented Sep 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@shwstppr couple of issues, not sure if they are due to the qa.cloudstack.cloud backend of 4.15.1: (the qa.cloudstack.cloud is SAMl enabled and can be used for testing)

  1. Check if the normal user/role type should be shown this form, it fails:

  2. On creating user as normal user type, that fails too (in its own account):

  3. As domain admin, the IDP list was somehow not shown in the create user form:

  4. As root admin, I created a new user 'rick' and while creating the user ticked authorise saml sso and selected the IDP however the newly-created user is not SAML2 type:

  5. For an already authorised saml user, when clicking edit saml authorisation button the IDP is pre-selected as 0 (something wrong in option/value key?)

Note: this form also seems to pass invalid entityid in the API, so the user isn't really SAML enabled.

@shwstppr please also test/fix any issues with the createAccount form (which also has the saml authorisation option).

Pearl1594 mentioned this pull request Sep 21, 2021
Closed
10 tasks
fix listIdp issue for add account/user
1f0f09c 
Fixes apache#5477

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr changed the title ui: fix create user with saml ui: fix create account/user with saml Sep 21, 2021

shwstppr commented Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

@rhtyd Verified mentioned issues with PR build:

  1. Normal User role cannot create new users in their own account. Old UI doesn't provide the option and option wasn't there in this PR build as well.
  2. Same as 1
  3. Fixed this case
  4. Fixed with this PR
  5. Didn't see this behaviour with this PR build.

Addressed #5477 and #5478
@blueorangutan ui

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Merge branch 'main' into fix-ui-create-user-saml
8f8d3ae
label fix
a493ba1 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr commented Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

shwstppr requested a review from Pearl1594 September 21, 2021 07:55

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

shwstppr requested review from Pearl1594, utchoang and yadvr and removed request for Pearl1594 September 21, 2021 07:55

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-674)

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-675)

utchoang approved these changes Sep 21, 2021
View reviewed changes

utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

yadvr commented Sep 21, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

yadvr approved these changes Sep 21, 2021
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - I'll test and confirm shortly

yadvr commented Sep 21, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-676)

yadvr commented Sep 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@shwstppr outstanding/new issues:

  1. Minor - does not refresh user detail page on edit/saving the authorise saml sso form
  2. As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid
  3. Minor - Create user form doesn't work for domain user the #/user path (as domainid is not passed)

fix idp selection
98c486f 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr commented Sep 21, 2021

Copy link
Copy Markdown
Member

@shwstppr is this ready for final test/merge, or you addressing minor issues too?
@blueorangutan ui

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Sep 21, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-678)

shwstppr commented Sep 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@rhtyd let's move ahead with one for 2

As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid

I'll fix 1 and 3 in another PR #5487

yadvr commented Sep 21, 2021

Copy link
Copy Markdown
Member

LGTM tested!

yadvr merged commit 67be3da into apache:main Sep 21, 2021
weizhouapache mentioned this pull request Mar 23, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
utchoang utchoang approved these changes
Pearl1594 Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

component:saml Severity:Critical Critical bug type:bug

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

Problem adding SAML user into a existing Account Problem adding SAML user as Domain Admin

4 participants

Back | FazBrowse Home | New Git URL