ui: List Identity providers as domain admin - #5482
Closed
Pearl1594 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
yadvr
reviewed
Sep 21, 2021
Comment thread
ui/src/views/iam/AddAccount.vue
| if ('listIdps' in this.$store.getters.apis) { | ||
| this.fetchIdps() | ||
| } | ||
| this.fetchIdps() |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Shouldn't we check that, otherwise it could fail @Pearl1594 cc @shwstppr
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Closing this as it can be handled as part of #5481 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The listIdps API doesn't actually have any authorization restriction based on user roles. However, it isn't part of the API list for roles other than root admin. Legacy UI, didn't enforce this check either. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes: #5477 wherein domain admins aren't allowed to list available IDPs.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?