FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support for parameter `cidrlist` added to the UI by JoaoJandre · Pull Request #6869 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Support for parameter cidrlist added to the UI - #6869

Merged
GutoVeronezi merged 1 commit into
apache:mainfrom
scclouds:UI-create-cidr-field-for-load-balancer-rules
Dec 20, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Support for parameter cidrlist added to the UI#6869
GutoVeronezi merged 1 commit into
apache:mainfrom
scclouds:UI-create-cidr-field-for-load-balancer-rules

Conversation

JoaoJandre commented Nov 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

PR #6460 reimplemented the cidrlist in API createLoadBalancerRule; However, this parameter was not implemented in the UI. This PRs intends to implement the cidrlist field in the create load balancer rule form.

This PR also fixes the BulkActionView.vue, which currently throws an exception when used.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

This was tested in a local lab, by running npm run serve and creating/deleting load balancer rules with cidrlists. The BulkActionView was also tested: before this change it was throwing an exception and was not opening the form. After the changes, it worked fine.

acs-robot commented Nov 3, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan commented Nov 3, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov Bot commented Nov 3, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6869 (504e267) into main (fa39e61) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #6869   +/-   ##
=========================================
  Coverage     10.84%   10.85%           
- Complexity     7104     7106    +2     
=========================================
  Files          2485     2485           
  Lines        245417   245417           
  Branches      38326    38326           
=========================================
+ Hits          26627    26631    +4     
+ Misses       215521   215515    -6     
- Partials       3269     3271    +2
Impacted Files Coverage Δ
...rg/apache/cloudstack/quota/QuotaStatementImpl.java 40.26% <0.00%> (ø)
...dstack/network/contrail/model/ModelObjectBase.java 28.84% <0.00%> (+7.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

BryanMLima approved these changes Nov 8, 2022
View reviewed changes

BryanMLima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

DaanHoogland reopened this Nov 8, 2022

DaanHoogland commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Nov 8, 2022

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

JoaoJandre commented Nov 30, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

blueorangutan commented Nov 30, 2022

Copy link
Copy Markdown

@JoaoJandre a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Nov 30, 2022

Copy link
Copy Markdown

UI build: ✖️
(SL-JID-2652)

DaanHoogland commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Dec 1, 2022

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Dec 1, 2022

Copy link
Copy Markdown

UI build: ✖️
(SL-JID-2655)

JoaoJandre commented Dec 19, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

blueorangutan commented Dec 19, 2022

Copy link
Copy Markdown

@JoaoJandre a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Dec 19, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/6869 (QA-JID-19)

GutoVeronezi approved these changes Dec 20, 2022
View reviewed changes

GutoVeronezi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CLGTM

GutoVeronezi commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

Merging this one based on the approvals and build result.

GutoVeronezi merged commit 440d780 into apache:main Dec 20, 2022
weizhouapache mentioned this pull request Jan 5, 2023
Merged
1 of 12 tasks

weizhouapache commented Jan 5, 2023

Copy link
Copy Markdown
Member

@GutoVeronezi @JoaoJandre @stephankruggg
Do you have QA engineer or mutually review/testing process ?

DaanHoogland added this to the 4.18.0.0 milestone Jan 5, 2023

GutoVeronezi commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

@GutoVeronezi @JoaoJandre @stephankruggg Do you have QA engineer or mutually review/testing process ?

@weizhouapache, yes, we have a process; however, as you may know by personal experience, sometimes some use cases are missed. Thanks for fixing the regression, we will pay more attention in next PRs.

weizhouapache commented Jan 10, 2023

Copy link
Copy Markdown
Member

@GutoVeronezi
thanks, good to know. no worries, bugs could happen.

I have a suggestion: If any of you have tested a PR, can you comment the PR that you have tested it, for example "manually tested ok" ? It would be much better if test steps and results are added as well.

GutoVeronezi mentioned this pull request Jun 28, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GutoVeronezi GutoVeronezi approved these changes
BryanMLima BryanMLima approved these changes
+1 more reviewer
stephankruggg stephankruggg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.18.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL