FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: fix cannot list lb rules if cidr_list is NULL by weizhouapache · Pull Request #7058 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

UI: fix cannot list lb rules if cidr_list is NULL - #7058

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
weizhouapache:4.18-ui-fix-list-lb-rules
Jan 9, 2023
ConversationCommits (1)ChecksFiles changed
Merged

UI: fix cannot list lb rules if cidr_list is NULL#7058
DaanHoogland merged 1 commit into
apache:mainfrom
weizhouapache:4.18-ui-fix-list-lb-rules

Conversation

weizhouapache commented Jan 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR fixes an UI issue that LB rules cannot be listed for kubernetes cluster.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache force-pushed the 4.18-ui-fix-list-lb-rules branch from 7c87b31 to bee009f Compare January 5, 2023 12:27

weizhouapache commented Jan 5, 2023

Copy link
Copy Markdown
Member Author

@JoaoJandre
this is a regression of #6869

weizhouapache mentioned this pull request Jan 5, 2023
Closed
weizhouapache self-assigned this Jan 5, 2023

sonarqubecloud Bot commented Jan 5, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

codecov Bot commented Jan 5, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7058 (bee009f) into main (16ec810) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7058   +/-   ##
=========================================
  Coverage     11.58%   11.58%           
  Complexity     7550     7550           
=========================================
  Files          2494     2494           
  Lines        247073   247073           
  Branches      38614    38614           
=========================================
  Hits          28633    28633           
  Misses       214695   214695           
  Partials       3745     3745

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yadvr added this to the 4.18.0.0 milestone Jan 9, 2023
GutoVeronezi approved these changes Jan 9, 2023
View reviewed changes

GutoVeronezi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

RodrigoDLopez approved these changes Jan 9, 2023
View reviewed changes

RodrigoDLopez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

DaanHoogland merged commit 602f22a into apache:main Jan 9, 2023
DaanHoogland deleted the 4.18-ui-fix-list-lb-rules branch January 11, 2023 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
GutoVeronezi GutoVeronezi approved these changes
+2 more reviewers
RodrigoDLopez RodrigoDLopez approved these changes
stephankruggg stephankruggg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

weizhouapache

Labels

component:UI

Projects

None yet

Milestone

4.18.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL