FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CLOUDSTACK-8745 : verify usage after root disk migration by nitt10prashant · Pull Request #713 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

CLOUDSTACK-8745 : verify usage after root disk migration - #713

Merged
asfgit merged 1 commit into
apache:masterfrom
nitt10prashant:pool_maint
Apr 25, 2016
ConversationCommits (1)ChecksFiles changed
Merged

CLOUDSTACK-8745 : verify usage after root disk migration#713
asfgit merged 1 commit into
apache:masterfrom
nitt10prashant:pool_maint

Conversation

nitt10prashant commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

put storage in maintenance mode and start ha vm and check usage ... === TestName: test_ha_with_storage_maintenance | Status : SUCCESS ===
ok

Ran 1 test in 842.294s

OK

asfbot commented Aug 18, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #342 ABORTED

asfbot commented Aug 18, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #1037 ABORTED

asfbot commented Aug 18, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #274 UNSTABLE
Looks like there's a problem with this pull request

ksowmya reviewed Aug 19, 2015
View reviewed changes
Comment thread test/integration/component/maint/test_ha_pool_maintenance.py Outdated

ksowmya Aug 19, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There are enableMaintenance and cancelMaintenance methods available now directly from StoragePool in base.py. It's better to use that instead of repeating?

nitt10prashant Aug 19, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

those methods can be used only with storage pool class object.

ksowmya Aug 19, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

hmm... I thought something like this should work: StoragePool.enableMaintenance(self.api_client, id=storageself.storageid[0][0]) since it is a classmethod
I am just trying to confirm you're using the latest base.py since couple of these enhancements went in recently into base.py...
If it still doesn't fit in, it's ok. You can continue the way you've done

nitt10prashant commented Aug 19, 2015

Copy link
Copy Markdown
Contributor Author

test result of enough storage is not available to perform test

put storage in maintenance mode and start ha vm and check usage ... SKIP: sufficient storage not available in any cluster for zone 90d85d89-01c4-4a91-b76e-eedf947b40f6

Ran 1 test in 4.059s

OK (SKIP=1)

asfbot commented Aug 19, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #349 ABORTED

asfbot commented Aug 19, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #281 ABORTED

sanju1010 commented Sep 14, 2015

Copy link
Copy Markdown
Contributor

LGTM!!

asfbot commented Sep 14, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #526 ABORTED

asfbot commented Sep 14, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #590 ABORTED

pavanb018 commented Sep 21, 2015

Copy link
Copy Markdown
Contributor

The test Looks good to me.

yadvr commented Jan 27, 2016

Copy link
Copy Markdown
Member

@nitt10prashant please rebase and meld into a single commit

nitt10prashant commented Mar 2, 2016

Copy link
Copy Markdown
Contributor Author

sure

CLOUDSTACK-8745 : verify usage after root disk migration
456abb0 
modified to use maintenance method is base.py and added some more checks

CLOUDSTACK-8745: Fail test if list response in empty

nitt10prashant commented Apr 22, 2016

Copy link
Copy Markdown
Contributor Author

@bhaisaab rebased and merged into single commit ,@swill @koushik-das can you please look into this

swill commented Apr 22, 2016

Copy link
Copy Markdown
Contributor

I need one more LGTM code review on this one. I will try to test this in my lab today. Thanks...

swill commented Apr 22, 2016

Copy link
Copy Markdown
Contributor

I think this one is ready unless anyone has any final words...

asfgit merged commit 456abb0 into apache:master Apr 25, 2016
asfgit pushed a commit that referenced this pull request Apr 25, 2016
Merge pull request #713 from nitt10prashant/pool_maint
a2d4692 
CLOUDSTACK-8745 : verify usage after root disk migrationput storage in maintenance mode and start ha vm and check usage ... === TestName: test_ha_with_storage_maintenance | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 842.294s

OK

* pr/713:
  CLOUDSTACK-8745 : verify usage after root disk migration

Signed-off-by: Will Stevens <williamstevens@gmail.com>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
config: extend basic customize theming options (#718)
8ad082d 
Customize link hover color
Customize loading color
Customize navigation menu color

Fixes #712
Fixes #713
Fixes #714

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL