FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names by yadvr · Pull Request #718 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names - #718

Closed
yadvr wants to merge 1 commit into
apache:4.5from
shapeblue:kvm-linklocal-cleanup
ConversationCommits (1)ChecksFiles changed
Closed

CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names#718
yadvr wants to merge 1 commit into
apache:4.5from
shapeblue:kvm-linklocal-cleanup

Conversation

yadvr commented Aug 19, 2015

Copy link
Copy Markdown
Member

This tries to avoid cleaning by a device name.

CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names
ee5638e 
This tries to avoid cleaning by a device name.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

asfbot commented Aug 19, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #352 ABORTED

remibergsma commented Aug 19, 2015

Copy link
Copy Markdown
Contributor

LGTM

asfbot commented Aug 19, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #284 ABORTED

milamberspace commented Aug 19, 2015

Copy link
Copy Markdown
Contributor

LGTM

remibergsma commented Aug 19, 2015

Copy link
Copy Markdown
Contributor

@bhaisaab Let's make sure this ends up in master as well!

asfgit pushed a commit that referenced this pull request Aug 19, 2015
CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names
74f697a 
This tries to avoid cleaning by a device name.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #718

yadvr commented Aug 19, 2015

Copy link
Copy Markdown
Member Author

@remibergsma thanks, done.

yadvr closed this Aug 19, 2015
asfgit pushed a commit that referenced this pull request Aug 19, 2015
CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names
3fd35dd 
This tries to avoid cleaning by a device name.

This closes #718

(cherry picked from commit 74f697a)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
jburwell reviewed Aug 19, 2015
View reviewed changes
Comment thread plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java

jburwell Aug 19, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am concerned about the unchecked array access in the event of malformed/unexpected input. Consider the following as a bit of extra safety in the event of malformed input beginning at line 289:

if (tokens != null && tokens.length < 2) {
   // Should we emit a log warning here to indicate that we received an unexpected string format?
   continue;
}

final String device = tokens[2];
if (!Strings.isNullOrEmpty(device) &&
    !device.equalsIgnoreCase(linkLocalBr)) {

yadvr Aug 19, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For this PR we cannot make any changes now that it is merged already; perhaps send a new PR or I can pick it up later.

yadvr added a commit to shapeblue/cloudstack that referenced this pull request Aug 24, 2015
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
86d29c4 
Based on @jburwell's comment on PR apache#718

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr mentioned this pull request Aug 24, 2015
Merged
yadvr added a commit to shapeblue/cloudstack that referenced this pull request Aug 24, 2015
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
972117e 
Based on @jburwell's comment on PR apache#718

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr mentioned this pull request Aug 24, 2015
Merged
yadvr added a commit to shapeblue/cloudstack that referenced this pull request Aug 26, 2015
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
7e455fa 
Based on @jburwell's comment on PR apache#718

This closes apache#735

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr added a commit to shapeblue/cloudstack that referenced this pull request Aug 26, 2015
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input
2a382e0 
Based on @jburwell's comment on PR apache#718

This closes apache#733

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
asfgit pushed a commit that referenced this pull request Aug 26, 2015
Merge pull request #735 from shapeblue/kvm-linkbr-checks-master
5d232ea 
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected inputBased on @jburwell's comment on PR #718

* pr/735:
  CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
asfgit pushed a commit that referenced this pull request Aug 26, 2015
Merge pull request #733 from shapeblue/kvm-linkbr-checks
acf1baf 
CLOUDSTACK-8749: Add checks to prevent malformed/unexpected inputBased on @jburwell's comment on PR #718

* pr/733:
  CLOUDSTACK-8749: Add checks to prevent malformed/unexpected input

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr pushed a commit that referenced this pull request Jan 20, 2021
config: extend basic customize theming options (#718)
8ad082d 
Customize link hover color
Customize loading color
Customize navigation menu color

Fixes #712
Fixes #713
Fixes #714

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL