Add a Makefile for convenience by jbampton · Pull Request #8491 · apache/cloudstack · GitHub

Description

The Makefile will contain the three main commands for using pre-commit locally.

At least this gives you a quickstart and place to see and run the pre-commit commands.

Makefiles can be very handy perhaps in future more commands can be added.

https://en.wikipedia.org/wiki/Make_(software)

refs apache/sedona#1183

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

BLOCKER
Critical
Major
Minor
Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

https://pre-commit.com/#4-optional-run-against-all-the-files https://pre-commit.com/#3-install-the-git-hook-scripts https://pre-commit.com/#pre-commit-autoupdate

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.65%. Comparing base (659f675) to head (6168570).
⚠️ Report is 238 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #8491   +/-   ##
=========================================
  Coverage     19.64%   19.65%           
- Complexity    19790    19792    +2     
=========================================
  Files          6368     6368           
  Lines        574889   574889           
  Branches      70353    70353           
=========================================
+ Hits         112962   112969    +7     
+ Misses       449656   449651    -5     
+ Partials      12271    12269    -2

Flag	Coverage Δ
uitests	3.41% <ø> (ø)
unittests	20.92% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ah, you are from the makestory :D

looks ok, I'm not sure of the use yet. can you explain the framework in use ; yarn, make. pre-commit? is this only for use in GHA?

-1 - we've GitHub actions for this, and I don't expect people to run it manually on their systems.

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

-1 - we've GitHub actions for this, and I don't expect people to run it manually on their systems.

I actually would expect seasoned developers to run this depending on the kind of changes they are making. that is to say the checks. if we add them to the pom file somehow that could work as well.

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Hi @jbampton is this PR ready for review or is it still in progress?

Pull request overview

Adds a repository-root Makefile to provide a simple local developer entrypoint for common pre-commit workflows, complementing the existing pre-commit documentation and CI workflow.

Changes:

Introduces make check to run pre-commit against all files.
Adds make checkinstall to install the git hook scripts.
Adds make checkupdate to autoupdate pre-commit hook revisions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Hi @jbampton is this PR ready for review or is it still in progress?

Hey @nvazquez yes this PR is now ready for review

Thanks @jbampton

Hi @yadvr @DaanHoogland can you please have a second review on this PR?

Thanks @jbampton

Hi @yadvr @DaanHoogland can you please have a second review on this PR?

I feel that any make mechs since make are an abundance. We have choosen for maven and I’ll honour that, but providing a makefile by someone who wants it for someone who wants it should never be blocked. (in case not clear: a big plusone on this)

Tested this locally. CI runs pre-commit twice, the second with --hook-stage manual. This is only the first, so the chmod hook never runs locally. Should check run both, or should the manual one be its own target?

checkinstall only writes .git/hooks/pre-commit. The config sets default_stages: [pre-commit, pre-push], so the pre-push hook never gets installed. Worth adding --hook-type pre-commit --hook-type pre-push?

Ran this and it rewrote .pre-commit-config.yaml, bumping four pins (doctoc, oxipng, codespell, markdownlint). Exits 0 with no sign it touched a tracked file. Can we note that in a comment here?

Bare make runs check, since it is the first target. Works, but should we set .DEFAULT_GOAL and add a help target? The three names do not say much on their own.

None of the targets check that pre-commit exists, so you just get "make: pre-commit: No such file or directory". Worth a guard?

Hi @jbampton can you please address the review comments?

Add a Makefile for convenience

66a6cc7

https://pre-commit.com/#4-optional-run-against-all-the-files https://pre-commit.com/#3-install-the-git-hook-scripts https://pre-commit.com/#pre-commit-autoupdate

boring-cyborg Bot added the component:build label Jan 10, 2024

yadvr reviewed Feb 5, 2024

View reviewed changes

jbampton marked this pull request as draft October 14, 2024 15:08

github-actions Bot added the status:has-conflicts label Oct 13, 2025

Merge branch 'main' into add-makefile-for-convenience

bb56e0f

github-actions Bot removed the status:has-conflicts label Oct 20, 2025

Merge branch 'main' into add-makefile-for-convenience

3b526c3

github-actions Bot added the status:has-conflicts label Oct 24, 2025

Merge

2b58d2f

github-actions Bot removed the status:has-conflicts label Nov 13, 2025

Fixup

3ff62ec

weizhouapache added this to the 4.24.0 milestone Jun 29, 2026

Merge branch 'main' into add-makefile-for-convenience

6168570

Copilot AI lite review requested due to automatic review settings August 13, 2026 02:42

Copilot started reviewing on behalf of jbampton August 13, 2026 02:43

View session

Copilot AI reviewed Aug 13, 2026

View reviewed changes

jbampton marked this pull request as ready for review August 13, 2026 03:29

DaanHoogland approved these changes Aug 14, 2026

View reviewed changes

DaanHoogland added this to CloudStack Testing Aug 31, 2026

github-project-automation Bot moved this to Backlog in CloudStack Testing Aug 31, 2026

DaanHoogland moved this from Backlog to Ready in CloudStack Testing Aug 31, 2026

DaanHoogland assigned Damans227 Sep 1, 2026

Damans227 reviewed Sep 8, 2026

View reviewed changes

Damans227 moved this from Ready to In progress in CloudStack Testing Sep 8, 2026

Damans227 moved this from In progress to Done in CloudStack Testing Sep 8, 2026

Damans227 moved this from Done to In review in CloudStack Testing Sep 8, 2026

jbampton marked this pull request as draft September 9, 2026 05:12

jbampton mentioned this pull request Sep 9, 2026

Switch from pre-commit to prek #14093

Open

nvazquez modified the milestones: 24.0, 25.0 Nov 1, 2026

+              # under the License.
+              check :
+              	pre-commit run --all-files

+              .PHONY : check
+              checkinstall :
+              	pre-commit install

+              .PHONY : checkinstall
+              checkupdate :
+              	pre-commit autoupdate

Add a Makefile for convenience by jbampton · Pull Request #8491 · apache/cloudstack · GitHub

Repository navigation

Add a Makefile for convenience - #8491

Add a Makefile for convenience#8491jbampton wants to merge 6 commits intoapache:mainapache/cloudstack:mainfrom jbampton:add-makefile-for-conveniencejbampton/cloudstack:add-makefile-for-convenienceCopy head branch name to clipboard

Conversation

jbampton commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov Bot commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland commented Jan 10, 2024

Uh oh!

DaanHoogland commented Jan 10, 2024

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 13, 2025

Uh oh!

DaanHoogland commented Oct 13, 2025

Uh oh!

github-actions Bot commented Oct 24, 2025

Uh oh!

nvazquez commented Aug 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jbampton commented Aug 13, 2026

Uh oh!

nvazquez commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Aug 14, 2026

Uh oh!

Damans227 Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 commented Sep 8, 2026

Uh oh!

nvazquez commented Oct 27, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Add a Makefile for convenience#8491
jbampton wants to merge 6 commits into
apache:mainfrom
jbampton:add-makefile-for-convenience

jbampton commented Jan 10, 2024 •
edited
Loading

codecov Bot commented Jan 10, 2024 •
edited
Loading

nvazquez commented Aug 13, 2026 •
edited
Loading