FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add a Makefile for convenience by jbampton · Pull Request #8491 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Add a Makefile for convenience #8491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jbampton wants to merge 6 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 18 Commits 6 Checks 27 Files changed
Draft

Add a Makefile for convenience #8491

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
66a6cc7
Add a Makefile for convenience
jbampton Jan 10, 2024
bb56e0f
Merge branch 'main' into add-makefile-for-convenience
jbampton Oct 20, 2025
3b526c3
Merge branch 'main' into add-makefile-for-convenience
jbampton Oct 24, 2025
2b58d2f
Merge
jbampton Nov 13, 2025
3ff62ec
Fixup
jbampton Nov 13, 2025
6168570
Merge branch 'main' into add-makefile-for-convenience
jbampton Aug 13, 2026
File filter

Filter by extension

Filter by extension No extension  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
28 changes: 28 additions & 0 deletions Makefile
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

check :

Damans227 Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Bare make runs check, since it is the first target. Works, but should we set .DEFAULT_GOAL and add a help target? The three names do not say much on their own.
pre-commit run --all-files

Damans227 Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tested this locally. CI runs pre-commit twice, the second with --hook-stage manual. This is only the first, so the chmod hook never runs locally. Should check run both, or should the manual one be its own target?
.PHONY : check

checkinstall :
pre-commit install

Damans227 Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

checkinstall only writes .git/hooks/pre-commit. The config sets default_stages: [pre-commit, pre-push], so the pre-push hook never gets installed. Worth adding --hook-type pre-commit --hook-type pre-push?
.PHONY : checkinstall

checkupdate :
pre-commit autoupdate

Damans227 Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ran this and it rewrote .pre-commit-config.yaml, bumping four pins (doctoc, oxipng, codespell, markdownlint). Exits 0 with no sign it touched a tracked file. Can we note that in a comment here?
.PHONY : checkupdate
Loading
Back | FazBrowse Home | New Git URL