FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix test/integration/smoke/test_register_userdata.py which caused networks not to be deleted by weizhouapache · Pull Request #9244 · apache/cloudstack · GitHub

/ cloudstack Public

test: fix test/integration/smoke/test_register_userdata.py which caused networks not to be deleted - #9244

Merged
DaanHoogland merged 1 commit into
apache:4.19from
weizhouapache:4.19-fix-test_register_userdata
Jun 14, 2024
ConversationCommits (1)ChecksFiles changed
Merged

test: fix test/integration/smoke/test_register_userdata.py which caused networks not to be deleted#9244
DaanHoogland merged 1 commit into
apache:4.19from
weizhouapache:4.19-fix-test_register_userdata

Conversation

weizhouapache commented Jun 13, 2024

Copy link
Copy Markdown
Member

Description

This PR fixes part of #8586

by moving the test under new domain/account instead of ROOT account

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

test: fix test/integration/smoke/test_register_userdata.py which caus…
a590078 
…ed networks not to be deleted

by moving the test under new domain/account instead of ROOT account
boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Jun 13, 2024
weizhouapache mentioned this pull request Jun 13, 2024
Closed
6 tasks
weizhouapache linked an issue Jun 13, 2024 that may be closed by this pull request
Stabilize the smoke test on xcp-ng 81/82 #8586
Closed
6 tasks

weizhouapache commented Jun 13, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Jun 13, 2024

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented Jun 13, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (19e9020) to head (a590078).

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9244      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    11015    11010       -5     
============================================
  Files          5377     5377              
  Lines        469605   469605              
  Branches      60258    58370    -1888     
============================================
- Hits          70296    70275      -21     
- Misses       391523   391548      +25     
+ Partials       7786     7782       -4
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan commented Jun 13, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9922

weizhouapache commented Jun 13, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan test rocky8 xcpng82

blueorangutan commented Jun 13, 2024

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests

blueorangutan commented Jun 14, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-10431)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server r8
Total time taken: 70781 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9244-t10431-xcpng82.zip
Smoke tests completed. 129 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_condensed_drs_algorithm Failure 169.60 test_cluster_drs.py
test_02_balanced_drs_algorithm Failure 180.76 test_cluster_drs.py
test_01_non_strict_host_anti_affinity Error 204.38 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 116.58 test_nonstrict_affinity_group.py

weizhouapache marked this pull request as ready for review June 14, 2024 06:20

weizhouapache commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

this is ready for review
@DaanHoogland @sureshanaparti

the rest failures are caused by live migration on xcpng82, see ##8586 #7340 (comment)

yadvr added this to the 4.19.1.0 milestone Jun 14, 2024
DaanHoogland approved these changes Jun 14, 2024
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

DaanHoogland merged commit 8d02e5f into apache:4.19 Jun 14, 2024
DaanHoogland deleted the 4.19-fix-test_register_userdata branch June 14, 2024 07:06

blueorangutan commented Jun 14, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-10440)
Environment: kvm-ubuntu24 (x2), Advanced Networking with Mgmt server u24
Total time taken: 47816 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9244-t10440-kvm-ubuntu24.zip
Smoke tests completed. 128 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_background_powerstate_sync Failure 21.01 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 31.48 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 20.07 test_outofbandmanagement.py
test_oobm_issue_power_off Error 20.05 test_outofbandmanagement.py
test_oobm_issue_power_on Error 20.04 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 20.05 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 20.06 test_outofbandmanagement.py
test_oobm_issue_power_status Error 20.04 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Failure 28.31 test_outofbandmanagement.py
test_oobm_zchange_password Error 6.50 test_outofbandmanagement.py
test_01_service_offering_cpu_limit_use Error 1.11 test_service_offerings.py
test_hostha_kvm_host_degraded Error 11.03 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 11.11 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 9.81 test_hostha_kvm.py

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
test: fix test/integration/smoke/test_register_userdata.py which caus…
63db3c6 
…ed networks not to be deleted (apache#9244)

by moving the test under new domain/account instead of ROOT account
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

No open projects
Apache CloudStack 4.19.1
Status: No status

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

Stabilize the smoke test on xcp-ng 81/82

4 participants

Back | FazBrowse Home | New Git URL