| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Codecov Report❌ Patch coverage is 77.49077% with 61 lines in your changes missing coverage. Please review. @@ Coverage Diff @@
## dev/1.3 #18461 +/- ##
=============================================
+ Coverage 44.46% 44.55% +0.09%
Complexity 198 198
=============================================
Files 3641 3646 +5
Lines 246603 246865 +262
Branches 30284 30326 +42
=============================================
+ Hits 109654 109999 +345
+ Misses 136949 136866 -83 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description
Backport the REST write request resource limits from #17481 to dev/1.3.
A crafted insertTablet or insertRecords request can contain an extremely large JSON body or a very large number of rows, columns, and values. Before this change, the REST layer deserialized and processed the payload without a bounded request-body or aggregate memory budget, which could exhaust DataNode heap under concurrent requests.
This change:
New configuration parameters:
For rest_max_total_concurrent_request_body_size_in_bytes, 0 uses half of the free-memory share configured by datanode_memory_proportion (5% of maximum heap with the default ratio), matching the budget used by the newer branch's auto-resizing buffer memory control. Negative values disable the corresponding limit.
Compatibility
The dev/1.3 REST implementation is part of the DataNode module and supports tree-model REST v1/v2 only. This backport therefore adapts the fix to javax.ws.rs and Java 8 and does not include the newer table-model REST endpoints.
Tests
14 tests passed with no failures or errors.