FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[To dev/1.3] Fix REST request limit filters after Jakarta migration by HTHou · Pull Request #18513 · apache/iotdb · GitHub

/ iotdb Public

[To dev/1.3] Fix REST request limit filters after Jakarta migration - #18513

Merged
HTHou merged 1 commit into
apache:dev/1.3from
HTHou:codex/fix-dev13-rest-jakarta
Aug 24, 2026
Merged

[To dev/1.3] Fix REST request limit filters after Jakarta migration#18513
HTHou merged 1 commit into
apache:dev/1.3from
HTHou:codex/fix-dev13-rest-jakarta

Conversation

HTHou commented Aug 24, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Description

#18461 added REST request size and concurrent request-body memory limits before #18499 migrated dev/1.3 from JavaX to Jakarta. Because the newly added limit filters were not present on the migration branch, they still imported javax.ws.rs after both PRs were merged, while the DataNode now provides the Jakarta JAX-RS API. This caused DataNode compilation to fail.

This PR migrates the JAX-RS imports in the REST request size filter, request-body memory manager/release filter, and the corresponding unit test from javax.ws.rs to jakarta.ws.rs.

There are no behavioral or configuration changes to the REST request limits.

Testing

mvn spotless:apply -pl iotdb-core/datanode
mvn test -pl iotdb-core/datanode -am \
  -Dtest=RequestSizeLimitFilterTest,RequestValidationLimitTest,IoTDBRestServiceDescriptorTest \
  -Dsurefire.failIfNoSpecifiedTests=false

The JDK 17 reactor build completed successfully for all 26 selected modules. All 14 REST request-limit tests passed.


This PR has:

  • been self-reviewed.
  • used existing unit tests to verify the migrated code.

Key changed classes
  • RequestSizeLimitFilter
  • RequestBodyMemoryReleaseFilter
  • RestRequestBodyMemoryManager
  • RequestSizeLimitFilterTest

HTHou merged commit 68e68b6 into apache:dev/1.3 Aug 24, 2026
14 of 16 checks passed
HTHou deleted the codex/fix-dev13-rest-jakarta branch August 24, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL