FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[To dev/1.3] Upgrade minimum JDK to 17 and migrate JavaX to Jakarta by HTHou · Pull Request #18499 · apache/iotdb · GitHub

/ iotdb Public

[To dev/1.3] Upgrade minimum JDK to 17 and migrate JavaX to Jakarta - #18499

Merged
HTHou merged 2 commits into
dev/1.3from
codex/upgrade-jdk17-jakarta-dev-1.3
Aug 24, 2026
ConversationCommits (2)ChecksFiles changed
Merged

[To dev/1.3] Upgrade minimum JDK to 17 and migrate JavaX to Jakarta#18499
HTHou merged 2 commits into
dev/1.3from
codex/upgrade-jdk17-jakarta-dev-1.3

Conversation

HTHou commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

Upgrade the minimum JDK version to 17

  • Require JDK 17 through Maven Enforcer and compiler settings.
  • Update GitHub Actions, Jenkins, startup scripts, examples, and documentation to use JDK 17.
  • Remove the obsolete JDK 8-only compile workflow.

Migrate Java EE APIs from JavaX to Jakarta

  • Migrate REST, Servlet, Validation, and related annotations to Jakarta namespaces.
  • Upgrade Jersey, Jetty, Swagger/OpenAPI, and Jakarta API dependencies accordingly.
  • Suppress generated Thrift Jakarta annotations that are not required at runtime.

Preserve dev/1.3 compatibility

  • Keep the dev/1.3-compatible TsFile, Thrift, Jackson, and ANTLR dependency lines instead of introducing master-only 2.x APIs.
  • Adapt the migration to REST and generated-code paths that exist only on dev/1.3.

Verification

  • mvn -T 1C -pl iotdb-core/datanode -am -DskipTests -Dspotless.skip=true compile
  • mvn -T 1C -pl iotdb-core/datanode -am -Dspotless.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=QueryDataSetHandlerTest,FastLastHandlerTest test
  • mvn -T 1C -pl iotdb-core/datanode -am -DskipTests spotless:check
  • mvn -P with-cpp -pl iotdb-client/client-cpp -Dspotless.skip=false spotless:check
  • Verified Maven Enforcer and CLI startup reject JDK 11.
  • Verified the DataNode dependency tree contains Jakarta APIs without legacy Java EE JavaX APIs.

This PR has:

  • been self-reviewed.
  • updated documentation for the modified minimum JDK requirement.
  • updated license information for the migrated dependencies.
  • updated unit tests for the migrated REST code paths.
Key changed/added classes (or packages if there are too many classes) in this PR
  • Root Maven build and dependency management
  • CI workflows and startup scripts
  • DataNode REST service and handlers
  • OpenAPI generator configuration

HTHou marked this pull request as ready for review August 20, 2026 06:30

sonarqubecloud Bot commented Aug 20, 2026

Copy link
Copy Markdown

Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

HTHou requested a balanced review from Copilot August 20, 2026 07:28
Copilot AI reviewed Aug 20, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

Raises IoTDB’s minimum JDK to 17 and migrates REST-related Java EE APIs from JavaX to Jakarta.

Changes:

  • Updates build, CI, launchers, examples, and documentation for JDK 17.
  • Migrates REST, Servlet, Validation, Jetty, Jersey, Swagger, and generated APIs to Jakarta.
  • Updates REST metadata handling and binary dependency licensing.

Reviewed changes

Copilot reviewed 68 out of 68 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
README.md Documents JDK 17 requirement.
README_ZH.md Updates Chinese JDK documentation.
pom.xml Updates Java baseline and Jakarta dependencies.
LICENSE-binary Revises bundled dependency inventory.
library-udf/pom.xml Targets Java 17.
Jenkinsfile Selects JDK 17.
iotdb-protocol/openapi/pom.xml Generates Jakarta/Jersey 3 REST code.
iotdb-core/node-commons/src/assembly/resources/sbin/health_check.sh Reports JDK 17 requirement.
iotdb-core/node-commons/src/assembly/resources/sbin/health_check.bat Reports JDK 17 requirement on Windows.
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template Updates OpenAPI endpoint documentation.
iotdb-core/datanode/src/test/resources/iotdb-system.properties Updates test configuration comments.
iotdb-core/datanode/src/test/resources/iotdb-common.properties Updates test configuration comments.
iotdb-core/datanode/src/test/java/org/apache/iotdb/db/protocol/rest/v2/handler/FastLastHandlerTest.java Migrates test response imports.
iotdb-core/datanode/src/test/java/org/apache/iotdb/db/protocol/rest/v1/handler/QueryDataSetHandlerTest.java Migrates test response imports.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionWorker.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/RestService.java Migrates Jetty and OpenAPI setup.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/view/visitor/TransformToExpressionVisitor.java Migrates JAX-RS exception.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/mnode/container/CachedMNodeContainer.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/mem/mnode/container/MemMNodeContainer.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/logfile/SchemaLogReader.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/logfile/FakeCRC32Deserializer.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/metedata/read/TimeSeriesSchemaScanNode.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/metedata/read/TimeSeriesCountNode.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/metedata/read/LevelTimeSeriesCountNode.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/expression/unary/InExpression.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/ConfigExecution.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/schedule/task/DriverTaskId.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v2/impl/RestApiServiceImpl.java Migrates JAX-RS types.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v2/impl/GrafanaApiServiceImpl.java Migrates JAX-RS types.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v2/handler/QueryDataSetHandler.java Migrates responses and adds result types.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v2/handler/FastLastHandler.java Migrates response type.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v2/handler/ExceptionHandler.java Migrates response status type.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v1/impl/RestApiServiceImpl.java Migrates JAX-RS types.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v1/impl/GrafanaApiServiceImpl.java Migrates JAX-RS types.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v1/handler/QueryDataSetHandler.java Migrates response type.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v1/handler/ExceptionHandler.java Migrates response status type.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/impl/PingApiServiceImpl.java Migrates JAX-RS types.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/handler/QueryRowLimitUtils.java Migrates response type.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/handler/AuthorizationHandler.java Migrates JAX-RS types.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/filter/BasicSecurityContext.java Migrates security context.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/filter/AuthorizationFilter.java Migrates filters and OpenAPI routing.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/filter/ApiOriginFilter.java Migrates Servlet filter APIs.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/memory/PipeDynamicMemoryBlock.java Migrates validation annotation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/rest/IoTDBRestServiceConfig.java Updates OpenAPI documentation.
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/audit/AuditLogger.java Migrates validation annotation.
iotdb-core/datanode/src/assembly/resources/sbin/start-datanode.bat Enforces JDK 17 on Windows.
iotdb-core/datanode/src/assembly/resources/conf/datanode-env.sh Enforces JDK 17 and simplifies JVM options.
iotdb-core/datanode/pom.xml Uses Jetty EE10 servlet.
iotdb-core/consensus/pom.xml Targets Java 17.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/mnode/container/ConfigMNodeContainer.java Migrates validation annotation.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaQuotaStatistics.java Migrates validation annotation.
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/response/cq/ShowCQResp.java Migrates validation annotation.
iotdb-core/confignode/src/assembly/resources/sbin/start-confignode.bat Enforces JDK 17 on Windows.
iotdb-core/confignode/src/assembly/resources/conf/confignode-env.sh Enforces JDK 17 and simplifies JVM options.
iotdb-client/session/src/test/resources/iotdb-common.properties Updates OpenAPI endpoint documentation.
iotdb-client/jdbc/README.md Documents JDBC JDK 17 requirement.
iotdb-client/client-cpp/README.md Documents JDK 17 Spotless baseline.
iotdb-client/client-cpp/pom.xml Activates C++ formatting on JDK 17+.
iotdb-client/cli/src/assembly/resources/sbin/start-cli.sh Enforces JDK 17 for Unix CLI.
integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppBaseConfig.java Migrates validation annotation.
example/pom.xml Targets Java 17.
example/pipe-count-point-processor/pom.xml Targets Java 17.
example/jdbc/pom.xml Targets Java 17.
.github/workflows/sonar-codecov.yml Runs analysis on JDK 21.
.github/workflows/multi-language-client.yml Adds JDK 17 setup.
.github/workflows/daily-ut.yml Standardizes daily tests on JDK 17.
.github/workflows/daily-it.yml Removes JDK 8 testing.
.github/workflows/compile-check.yml Removes obsolete JDK 8 workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pom.xml
Comment thread iotdb-client/cli/src/assembly/resources/sbin/start-cli.sh
Comment thread LICENSE-binary

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.79%. Comparing base (6ac48ee) to head (fd0fc91).

Files with missing lines Patch % Lines
...b/db/protocol/rest/filter/AuthorizationFilter.java 0.00% 8 Missing ⚠️
...iotdb/db/protocol/rest/filter/ApiOriginFilter.java 0.00% 1 Missing ⚠️
.../protocol/rest/v2/handler/QueryDataSetHandler.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##             dev/1.3   #18499      +/-   ##
=============================================
- Coverage      44.80%   44.79%   -0.01%     
  Complexity       198      198              
=============================================
  Files           3646     3646              
  Lines         248109   247947     -162     
  Branches       30596    30582      -14     
=============================================
- Hits          111155   111064      -91     
+ Misses        136954   136883      -71

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

HTHou merged commit e47fa92 into dev/1.3 Aug 24, 2026
25 of 27 checks passed
HTHou deleted the codex/upgrade-jdk17-jakarta-dev-1.3 branch August 24, 2026 07:52
HTHou mentioned this pull request Aug 24, 2026
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
JackieTien97 JackieTien97 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL