FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[doc][broker][monitoring] add message_ack_rate metric doc by tjiuming · Pull Request #15790 · apache/pulsar · GitHub

/ pulsar Public

[doc][broker][monitoring] add message_ack_rate metric doc - #15790

Merged
Anonymitaet merged 4 commits into
apache:masterfrom
tjiuming:dev/message_ack_rate_doc
Jul 4, 2022
ConversationCommits (4)ChecksFiles changed
Merged

[doc][broker][monitoring] add message_ack_rate metric doc#15790
Anonymitaet merged 4 commits into
apache:masterfrom
tjiuming:dev/message_ack_rate_doc

Conversation

tjiuming commented May 25, 2022 •
edited by Anonymitaet
Loading

Copy link
Copy Markdown
Contributor

Motivation

doc for #15674

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

github-actions Bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. doc-not-needed Your PR changes do not impact docs and removed doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels May 25, 2022

github-actions Bot commented May 26, 2022

Copy link
Copy Markdown

@tjiuming:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

github-actions Bot added doc-label-missing doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-not-needed Your PR changes do not impact docs labels May 26, 2022
Anonymitaet mentioned this pull request May 26, 2022
Closed
4 tasks
sijie mentioned this pull request May 26, 2022
Open
4 tasks
momo-jun reviewed Jun 13, 2022
View reviewed changes
Comment thread site2/docs/reference-metrics.md Outdated
momo-jun reviewed Jun 13, 2022
View reviewed changes
Comment thread site2/docs/reference-metrics.md Outdated
momo-jun approved these changes Jun 14, 2022
View reviewed changes

momo-jun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

momo-jun commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

Ping @Anonymitaet.

tjiuming commented Jul 2, 2022

Copy link
Copy Markdown
Contributor Author

@Anonymitaet Please help merge the PR

github-actions Bot added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-complete Your PR changes impact docs and the related docs have been already added. doc-label-missing labels Jul 4, 2022

Anonymitaet commented Jul 4, 2022

Copy link
Copy Markdown
Member

These checks are skipped, can I merge this PR? @tjiuming

tjiuming commented Jul 4, 2022

Copy link
Copy Markdown
Contributor Author

These checks are skipped, can I merge this PR? @tjiuming

All the required CI checks passed, I believe it's able to merge

Anonymitaet merged commit b0c9cc1 into apache:master Jul 4, 2022
Anonymitaet added this to the 2.11.0 milestone Jul 4, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Jul 5, 2022
[doc][broker][monitoring] add message_ack_rate metric doc (apache#15790)
0ccb536
wuxuanqicn pushed a commit to wuxuanqicn/pulsar that referenced this pull request Jul 14, 2022
[doc][broker][monitoring] add message_ack_rate metric doc (apache#15790)
bc0524a
tjiuming deleted the dev/message_ack_rate_doc branch August 14, 2022 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

codelipenghui codelipenghui approved these changes
momo-jun momo-jun approved these changes

Assignees

tjiuming

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL