FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[broker][monitoring] add message ack rate metric for consumer by tjiuming · Pull Request #15674 · apache/pulsar · GitHub

  1. apache
  2. pulsar

Repository navigation

[broker][monitoring] add message ack rate metric for consumer - #15674

Merged
mattisonchao merged 7 commits into
apache:masterfrom
tjiuming:dev/msg_ack_rate
Jun 13, 2022
ConversationCommits (7)ChecksFiles changed
Merged

[broker][monitoring] add message ack rate metric for consumer#15674
mattisonchao merged 7 commits into
apache:masterfrom
tjiuming:dev/msg_ack_rate

Conversation

tjiuming commented May 19, 2022 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Motivation

Currently, we have dispatch rate metrics but don't have consumer acknowledgment-related metrics.
Which not easy to troubleshoot issues like some consumers stop acknowledging messages.

Having an ack rate metric would be very useful to determine if our consumers are processing messages properly.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • no-need-doc
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-added
    (Docs have been already added)

  • doc-complete

github-actions Bot commented May 19, 2022

Copy link
Copy Markdown

@tjiuming:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

tjiuming changed the title [broker][monitoring] add message [broker][monitoring] add message ack rate metric for consumer May 19, 2022

github-actions Bot commented May 19, 2022

Copy link
Copy Markdown

@tjiuming:Thanks for providing doc info!

github-actions Bot added doc-required Your PR changes impact docs and you will update later. and removed doc-label-missing labels May 19, 2022

tjiuming commented May 19, 2022

Copy link
Copy Markdown
Contributor Author

Tests to be completed.

mattisonchao added this to the 2.11.0 milestone May 19, 2022
tjiuming mentioned this pull request May 25, 2022
Merged
1 of 4 tasks

tjiuming commented Jun 7, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

codelipenghui commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

/pulsarbot run-failure-checks

mattisonchao merged commit 88b47e5 into apache:master Jun 13, 2022
codelipenghui pushed a commit that referenced this pull request Jun 13, 2022
[broker][monitoring] add message ack rate metric for consumer (#15674)
9796eb4 
(cherry picked from commit 88b47e5)
codelipenghui mentioned this pull request Jun 13, 2022
Merged
1 of 3 tasks

mattisonchao commented Jun 13, 2022

Copy link
Copy Markdown
Member

Hi @tjiuming
It looks like many conflicts in branch-2.9. I'm not sure if I missing some dependency PR need to merge before this.
Could you please push a new PR for branch-2.9?

Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Jun 13, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jun 13, 2022
[broker][monitoring] add message ack rate metric for consumer (apache…
91ea447 
…#15674)

(cherry picked from commit 88b47e5)
(cherry picked from commit 9796eb4)

dave2wave commented Jun 13, 2022

Copy link
Copy Markdown
Member

Why is something that is NOT A BUG FIX being cherry picked to 2.9 and 2.8?

If there is any difficulty this is a risky change that might break an old branch.

michaeljmarshall commented Jun 13, 2022

Copy link
Copy Markdown
Member

add message ack rate metric for consumer

@tjiuming - can you please provide more motivation for this addition?

github-actions Bot added doc-required Your PR changes impact docs and you will update later. and removed doc-complete Your PR changes impact docs and the related docs have been already added. labels Jun 14, 2022

codelipenghui commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

@michaeljmarshall @dave2wave I have updated the motivation of this PR

Currently, we don't have message acknowledgment metrics, which is hard to find the ack-related issues.
With this improvement, users can add alerts and dashboards to the acknowledgment behavior of consumers.
So that they can know if consumers are processing messages properly.

It's not a new feature, just to improve the observability of the acknowledgment.
The metrics and logs can help to find the problem.

And I have mentioned this part on the mailing list https://lists.apache.org/thread/wkm1slrg341kbq7m83nms97df28kl4of
But looks like only @michaeljmarshall and I join the discussion. thanks @michaeljmarshall You have started a valuable discussion. We're a little fuzzy on the cherry-picking, I think we can get a clear cherry-pick criteria on the mailing list.
If the metrics and logs cherry-pick are not acceptable, I think we can discuss the mailing list first. Just based on my previous experience, without the logs and metrics, users are hard to detect problems and collect more context about a BUG. The logs and metrics can help pulsar's developers understand the problem.

Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Jun 14, 2022
This was referenced Jun 17, 2022
Merged
Merged
mattisonchao added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Jul 2, 2022
BewareMyPower mentioned this pull request Jul 27, 2022
Merged
1 task done
BewareMyPower pushed a commit that referenced this pull request Jul 27, 2022
[broker][monitoring] add message ack rate metric for consumer (#15674)
baf35d2 
(cherry picked from commit 88b47e5)
BewareMyPower added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Technoboy- Technoboy- approved these changes
codelipenghui codelipenghui approved these changes
mattisonchao mattisonchao approved these changes

Assignees

tjiuming

Labels

cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-complete Your PR changes impact docs and the related docs have been already added. release/2.8.4 release/2.9.4 release/2.10.1

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL