Repository navigation
[fix][broker][monitoring] fix message ack rate - #16108
Merged
codelipenghui merged 3 commits intoJun 21, 2022
Merged
codelipenghui merged 3 commits into
codelipenghui merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
codelipenghui
approved these changes
Jun 20, 2022
1 of 4 tasks
Copy link
Copy Markdown
Contributor
|
@tjiuming Please check the failed test Error: Tests run: 15, Failures: 1, Errors: 0, Skipped: 11, Time elapsed: 35.275 s <<< FAILURE! - in org.apache.pulsar.broker.stats.ConsumerStatsTest Error: testPersistentTopicMessageAckRateMetricNamespaceLevel(org.apache.pulsar.broker.stats.ConsumerStatsTest) Time elapsed: 1.558 s <<< FAILURE! java.lang.AssertionError: expected [2] but found [0] at org.testng.Assert.fail(Assert.java:99) at org.testng.Assert.failNotEquals(Assert.java:1037) at org.testng.Assert.assertEqualsImpl(Assert.java:140) at org.testng.Assert.assertEquals(Assert.java:122) at org.testng.Assert.assertEquals(Assert.java:907) at org.testng.Assert.assertEquals(Assert.java:917) at org.apache.pulsar.broker.stats.ConsumerStatsTest.testMessageAckRateMetric(ConsumerStatsTest.java:299) at org.apache.pulsar.broker.stats.ConsumerStatsTest.testPersistentTopicMessageAckRateMetricNamespaceLevel(ConsumerStatsTest.java:248) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132) at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45) at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73) at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:833) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@codelipenghui Fixed batch messages ack rate, PTAL |
Sorry, something went wrong.
codelipenghui
pushed a commit
that referenced
this pull request
Jun 28, 2022
(cherry picked from commit 8869d8c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fix PR.15674, there was a incorrect API usage in it, need to fix.
Modifications
fix issue
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)