FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: specify correct MSRV in Cargo.toml by xtqqczze · Pull Request #2837 · ast-grep/ast-grep · GitHub

fix: specify correct MSRV in Cargo.toml - #2837

Merged
HerringtonDarkholme merged 1 commit into
ast-grep:mainfrom
xtqqczze:msrv
Jul 22, 2026
Merged

HerringtonDarkholme merged 1 commit into
ast-grep:mainfrom
xtqqczze:msrv

Conversation

xtqqczze commented Jul 22, 2026
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

See also: #2836

Summary by CodeRabbit

  • Chores
    • Updated the minimum supported Rust toolchain version to 1.88.0.

coderabbitai Bot commented Jul 22, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

📝 Walkthrough

Walkthrough

The workspace minimum Rust toolchain requirement was raised from 1.85 to 1.88.0 in Cargo.toml.

Changes

Rust toolchain requirement

Layer / File(s) Summary
Update workspace Rust version
Cargo.toml
The workspace rust-version requirement changes from 1.85 to 1.88.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: herringtondarkholme

Poem

A bunny hops through Cargo’s door,
“Rust one-eight-eight!” it cries with cheer.
One tiny line, a version new,
The workspace springs with tools anew.

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the change: updating the MSRV in Cargo.toml.
✨ Finishing Touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
🧹 Nitpick comments (1)
Cargo.toml (1)

20-20: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add an explicit MSRV CI check for Rust 1.88.0.

The supplied workflow installs stable, which may conceal code that fails on the declared MSRV. Add or verify a CI job pinned to 1.88.0 that runs the relevant checks.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Cargo.toml` at line 20, Add or update the CI workflow to include a dedicated
job using Rust 1.88.0, rather than stable, and run the project’s relevant checks
there. Keep the existing stable workflow intact while ensuring the pinned MSRV
job validates the code against the rust-version declared in Cargo.toml.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Cargo.toml`:
- Line 20: Add or update the CI workflow to include a dedicated job using Rust
1.88.0, rather than stable, and run the project’s relevant checks there. Keep
the existing stable workflow intact while ensuring the pinned MSRV job validates
the code against the rust-version declared in Cargo.toml.

ℹ️ Review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 90c0f0d5-615c-437e-b544-5e5ed8bac3a9

📥 Commits

Reviewing files that changed from the base of the PR and between 6dc0f31 and 3135506.

📒 Files selected for processing (1)
  • Cargo.toml

HerringtonDarkholme added this pull request to the merge queue Jul 22, 2026
Merged via the queue into ast-grep:main with commit 89c9110 Jul 22, 2026
4 checks passed
xtqqczze deleted the msrv branch July 22, 2026 14:59
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
ast-grep 0.45.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>- feat: deprecate the sg command [`#2843`](ast-grep/ast-grep#2843)
- fix: avoid Defender false positive for Windows sg [`#2842`](ast-grep/ast-grep#2842)
- chore(deps): update dependency @napi-rs/cli to v3.7.4 [`#2834`](ast-grep/ast-grep#2834)
- chore(deps): update dependency oxlint to v1.75.0 [`#2838`](ast-grep/ast-grep#2838)
- chore(deps): update actions/setup-node action to v7 [`#2810`](ast-grep/ast-grep#2810)
- chore(deps): update actions/setup-python action to v7 [`#2829`](ast-grep/ast-grep#2829)
- fix: specify correct MSRV in Cargo.toml [`#2837`](ast-grep/ast-grep#2837)
- Revert "chore(deps): update dependency typescript to v7 (#2795)" [`#2831`](ast-grep/ast-grep#2831)
- chore(deps): update astral-sh/setup-uv action to v8.3.2 [`#2790`](ast-grep/ast-grep#2790)
- chore(deps): update dependency typescript to v7 [`#2795`](ast-grep/ast-grep#2795)
- chore(deps): update rust crate thiserror to v2.0.19 [`#2819`](ast-grep/ast-grep#2819)
- chore(deps): update dependency @napi-rs/cli to v3.7.3 [`#2801`](ast-grep/ast-grep#2801)
- chore(deps): update dependency web-tree-sitter to v0.26.11 [`#2802`](ast-grep/ast-grep#2802)
- chore(deps): update rust crate target-triple to v1.0.1 [`#2817`](ast-grep/ast-grep#2817)
- chore(deps): update dependency oxlint to v1.74.0 [`#2809`](ast-grep/ast-grep#2809)
- chore(deps): update dependency dprint to v0.55.2 [`#2808`](ast-grep/ast-grep#2808)
- chore(deps): update dependency @ast-grep/napi to v0.44.1 [`#2789`](ast-grep/ast-grep#2789)
- chore(deps): update dependency oxlint to v1.73.0 [`#2793`](ast-grep/ast-grep#2793)
- chore(deps): update dependency @types/node to v24.13.3 [`#2794`](ast-grep/ast-grep#2794)
- chore(deps): update rust crate bit-set to 0.11.0 [`#2791`](ast-grep/ast-grep#2791)
- fix: use is_extra instead of comment heuristic [`#2821`](ast-grep/ast-grep#2821)
- fix: stop using ignore files outside rule_dirs [`#2803`](ast-grep/ast-grep#2803)
- chore: update dependencies [`b24ca85`](ast-grep/ast-grep@b24ca85)
- feat(outline): support ambient TypeScript modules [`4f75c21`](ast-grep/ast-grep@4f75c21)
- chore: bump versions [`82eb291`](https://github.com/ast-grep/ast-grep/commit/82eb2916782ae5ed572813272f5845214b5aa321)</pre>
  <p>View the full release notes at <a href="https://github.com/ast-grep/ast-grep/releases/tag/0.45.0">https://github.com/ast-grep/ast-grep/releases/tag/0.45.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!14931
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL