| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
📝 Walkthrough
WalkthroughThe workspace minimum Rust toolchain requirement was raised from 1.85 to 1.88.0 in Cargo.toml. ChangesRust toolchain requirement
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: herringtondarkholme Poem 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
There was a problem hiding this comment.
Cargo.toml (1)🤖 Prompt for all review comments with AI agents20-20: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Add an explicit MSRV CI check for Rust 1.88.0.
The supplied workflow installs stable, which may conceal code that fails on the declared MSRV. Add or verify a CI job pinned to 1.88.0 that runs the relevant checks.
🤖 Prompt for AI AgentsVerify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Cargo.toml` at line 20, Add or update the CI workflow to include a dedicated job using Rust 1.88.0, rather than stable, and run the project’s relevant checks there. Keep the existing stable workflow intact while ensuring the pinned MSRV job validates the code against the rust-version declared in Cargo.toml.
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Nitpick comments: In `@Cargo.toml`: - Line 20: Add or update the CI workflow to include a dedicated job using Rust 1.88.0, rather than stable, and run the project’s relevant checks there. Keep the existing stable workflow intact while ensuring the pinned MSRV job validates the code against the rust-version declared in Cargo.toml.
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 90c0f0d5-615c-437e-b544-5e5ed8bac3a9
📥 CommitsReviewing files that changed from the base of the PR and between 6dc0f31 and 3135506.
📒 Files selected for processing (1)
Sorry, something went wrong.
ast-grep 0.45.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>- feat: deprecate the sg command [`#2843`](ast-grep/ast-grep#2843) - fix: avoid Defender false positive for Windows sg [`#2842`](ast-grep/ast-grep#2842) - chore(deps): update dependency @napi-rs/cli to v3.7.4 [`#2834`](ast-grep/ast-grep#2834) - chore(deps): update dependency oxlint to v1.75.0 [`#2838`](ast-grep/ast-grep#2838) - chore(deps): update actions/setup-node action to v7 [`#2810`](ast-grep/ast-grep#2810) - chore(deps): update actions/setup-python action to v7 [`#2829`](ast-grep/ast-grep#2829) - fix: specify correct MSRV in Cargo.toml [`#2837`](ast-grep/ast-grep#2837) - Revert "chore(deps): update dependency typescript to v7 (#2795)" [`#2831`](ast-grep/ast-grep#2831) - chore(deps): update astral-sh/setup-uv action to v8.3.2 [`#2790`](ast-grep/ast-grep#2790) - chore(deps): update dependency typescript to v7 [`#2795`](ast-grep/ast-grep#2795) - chore(deps): update rust crate thiserror to v2.0.19 [`#2819`](ast-grep/ast-grep#2819) - chore(deps): update dependency @napi-rs/cli to v3.7.3 [`#2801`](ast-grep/ast-grep#2801) - chore(deps): update dependency web-tree-sitter to v0.26.11 [`#2802`](ast-grep/ast-grep#2802) - chore(deps): update rust crate target-triple to v1.0.1 [`#2817`](ast-grep/ast-grep#2817) - chore(deps): update dependency oxlint to v1.74.0 [`#2809`](ast-grep/ast-grep#2809) - chore(deps): update dependency dprint to v0.55.2 [`#2808`](ast-grep/ast-grep#2808) - chore(deps): update dependency @ast-grep/napi to v0.44.1 [`#2789`](ast-grep/ast-grep#2789) - chore(deps): update dependency oxlint to v1.73.0 [`#2793`](ast-grep/ast-grep#2793) - chore(deps): update dependency @types/node to v24.13.3 [`#2794`](ast-grep/ast-grep#2794) - chore(deps): update rust crate bit-set to 0.11.0 [`#2791`](ast-grep/ast-grep#2791) - fix: use is_extra instead of comment heuristic [`#2821`](ast-grep/ast-grep#2821) - fix: stop using ignore files outside rule_dirs [`#2803`](ast-grep/ast-grep#2803) - chore: update dependencies [`b24ca85`](ast-grep/ast-grep@b24ca85) - feat(outline): support ambient TypeScript modules [`4f75c21`](ast-grep/ast-grep@4f75c21) - chore: bump versions [`82eb291`](https://github.com/ast-grep/ast-grep/commit/82eb2916782ae5ed572813272f5845214b5aa321)</pre> <p>View the full release notes at <a href="https://github.com/ast-grep/ast-grep/releases/tag/0.45.0">https://github.com/ast-grep/ast-grep/releases/tag/0.45.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!14931
| Back | FazBrowse Home | New Git URL |
See also: #2836
Summary by CodeRabbit