Pull request overview

This PR deprecates the sg command by emitting a prominent warning on every invocation and directing users to ast-grep, across Rust binaries and npm-distributed shims/binaries.

Changes:

• Add a deprecation warning to the npm sg JavaScript shim (stderr), preserving warnings even when lifecycle scripts don’t run.
• Update npm postinstall logic to install both ast-grep and sg native binaries from platform packages.
• Add sg to the shipped files for each native npm platform package and add an integration test asserting the warning appears on stderr.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

crates/cli/src/bin/alias.rs:28

• On Unix this launcher executes ast-grep by name (Command::new("ast-grep")), which relies on PATH. When sg is invoked via an absolute path (common for npm-generated wrappers executing the binary directly), PATH may not include the directory containing ast-grep, causing sg to fail to forward.

Prefer resolving a sibling ast-grep next to the current sg executable (and fall back to PATH search if it’s not found).

  print_deprecation_warning();
  let mut child = Command::new("ast-grep")
    .args(args().skip(1))
    .stdin(Stdio::inherit())
    .stdout(Stdio::inherit())

npm/postinstall.js (1)

54-61: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Swallowed errors hinder install failure diagnosis.

Both installBinary's fallback and main's catch discard the underlying error (catch (_)), so if both linkSync and copyFileSync fail, users only see a generic message with no indication of which binary failed or why (permissions, missing source, disk full, etc.).

♻️ Proposed fix to surface the underlying error

 function installBinary(src, dest) {
   try {
     fs.linkSync(src, dest);
-  } catch (_) {
-    fs.copyFileSync(src, dest);
+  } catch (_) {
+    fs.copyFileSync(src, dest);
   }
 }
 ...
   try {
     installBinary(src, destBin);
     installBinary(srcAlt, destAlt);
-  } catch (_) {
-    console.error("Failed to move `@ast-grep/cli` binaries into place.");
+  } catch (err) {
+    console.error("Failed to move `@ast-grep/cli` binaries into place.", err);
     process.exit(1);
   }

Also applies to: 74-80

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@npm/postinstall.js` around lines 54 - 61, Update installBinary and main error
handling to preserve and surface the original errors instead of discarding them
with catch (_). When linkSync fails, retain its error and include it alongside
any copyFileSync failure; ensure main’s failure message identifies the affected
binary and includes the underlying error details.

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@npm/postinstall.js`:
- Around line 54-61: Update installBinary and main error handling to preserve
and surface the original errors instead of discarding them with catch (_). When
linkSync fails, retain its error and include it alongside any copyFileSync
failure; ensure main’s failure message identifies the affected binary and
includes the underlying error details.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d9b0283e-b308-4b75-ad2e-dbd74724a322

Reviewing files that changed from the base of the PR and between 64d2a26 and c889def.

• crates/cli/src/bin/alias.rs
• crates/cli/tests/help_test.rs
• npm/platforms/darwin-arm64/package.json
• npm/platforms/darwin-x64/package.json
• npm/platforms/linux-arm64-gnu/package.json
• npm/platforms/linux-x64-gnu/package.json
• npm/platforms/win32-arm64-msvc/package.json
• npm/platforms/win32-ia32-msvc/package.json
• npm/platforms/win32-x64-msvc/package.json
• npm/postinstall.js
• npm/sg