FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

TST: Skip segfault test case instead of xfail by pllim · Pull Request #8160 · astropy/astropy · GitHub

/ astropy Public

TST: Skip segfault test case instead of xfail - #8160

Merged
astrofrog merged 1 commit into
astropy:masterfrom
pllim:lim-segfault-fix
Nov 20, 2018
ConversationCommits (1)ChecksFiles changed
Merged

TST: Skip segfault test case instead of xfail#8160
astrofrog merged 1 commit into
astropy:masterfrom
pllim:lim-segfault-fix

Conversation

pllim commented Nov 19, 2018

Copy link
Copy Markdown
Member

Fix #8148

I am very perplexed on why this only happens to me. But given that this particular test has a known recursion problem, it really does not matter whether we skip or xfail, but unfortunately the latter gives me seg fault.

pllim added this to the v3.1 milestone Nov 19, 2018
pllim requested a review from drdavella November 19, 2018 18:26

astropy-bot Bot commented Nov 19, 2018 •
edited
Loading

Copy link
Copy Markdown

Hi there @pllim 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

pllim mentioned this pull request Nov 19, 2018
Closed

codecov Bot commented Nov 19, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8160 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8160   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files         383      383           
  Lines       57860    57860           
  Branches     1056     1056           
=======================================
  Hits        50296    50296           
  Misses       6950     6950           
  Partials      614      614
Impacted Files Coverage Δ
astropy/logger.py 79.32% <0%> (-0.43%) ⬇️
astropy/samp/hub.py 77.52% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afe2af...1b5c3c4. Read the comment docs.

astrofrog merged commit 392d36b into astropy:master Nov 20, 2018
pllim deleted the lim-segfault-fix branch November 20, 2018 19:00
bsipocz pushed a commit that referenced this pull request Nov 23, 2018
Merge pull request #8160 from pllim/lim-segfault-fix
9149ad2 
TST: Skip segfault test case instead of xfail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

astrofrog astrofrog approved these changes
drdavella Awaiting requested review from drdavella

Assignees

No one assigned

Labels

logging no-changelog-entry-needed testing ¯\_(ツ)_/¯

Projects

None yet

Milestone

v3.1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL