FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Repo Cleanup by Cadair · Pull Request #47 · astropy/astropy-sphinx-theme · GitHub

Repo Cleanup - #47

Merged
astrofrog merged 14 commits into
astropy:mainfrom
Cadair:repo-cleanup
Jan 22, 2026
Merged

Repo Cleanup#47
astrofrog merged 14 commits into
astropy:mainfrom
Cadair:repo-cleanup

Conversation

Cadair commented Jan 21, 2026
edited by astrofrog
Loading

Copy link
Copy Markdown
Member

closes #36
closes #44

Also generally updates things before I add the new theme.

Can someone with the requisite permissions please add:

  • pre-commit.ci to this repo
  • Also add the build wheels label to this PR
  • The tokens to add a circleci artifact job like this.

Cadair commented Jan 21, 2026

Copy link
Copy Markdown
Member Author

There's a test build of astroquery here: https://astroquery--3505.org.readthedocs.build/en/3505/ with these changes just to make sure nothing untoward happened.

Comment thread .circleci/config.yml Outdated

bsipocz commented Jan 21, 2026

Copy link
Copy Markdown
Member

I added the label and the repo secret (and the redirect job), but I don't think most of it will have any effects until those configs lands on main (circleCI and the redirect certainly doesn't usually like changes in PRs and work off of main.

Copy link
Copy Markdown
Member

Just out of curiosity could we actually use RTD for the preview instead of CircleCI?

Cadair commented Jan 21, 2026

Copy link
Copy Markdown
Member Author

We should probably setup RTD as well to test the RTD specific stuff, but the reason I went with circle is so I can build a version with both themes in #48

bsipocz commented Jan 21, 2026

Copy link
Copy Markdown
Member

What did I do and why?

Cadair commented Jan 21, 2026

Copy link
Copy Markdown
Member Author

It's ok it didn't actually upload. I've not actually used this trusted publishing thing before

bsipocz commented Jan 21, 2026

Copy link
Copy Markdown
Member

But shouldn't it be just triggered when ready? I mean that messaging in the middle of a non-passing PR is disturbing to say the least.

Cadair commented Jan 21, 2026

Copy link
Copy Markdown
Member Author

Yeah it's weird I'll have a play tomorrow

Cadair commented Jan 22, 2026

Copy link
Copy Markdown
Member Author

@bsipocz I modified the release workflow to only hit the upload action on tags, not on PRs with the wheel label.

astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good overall! Just a couple minor comments, but not critical, so approving from my side.

Comment thread docs/colors.rst Outdated
Comment thread docs/colors.rst
<span class="sd-sphinx-override sd-badge pst-badge pst-target">target</span>
</p>

This theme uses shadows to convey depth in the light theme mode and opacity in the dark one.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Technically is this specific to the pydata theme?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Well the test code is it uses their css variables.

Cadair commented Jan 22, 2026

Copy link
Copy Markdown
Member Author

@astrofrog @bsipocz can we merge this? 👼

Copy link
Copy Markdown
Member

I didn't see any objections from @bsipocz before and this is mainly infrastructural anyway, so let's go ahead so it doesn't hold back your other work.

astrofrog merged commit 3d11a6f into astropy:main Jan 22, 2026
5 checks passed
Cadair deleted the repo-cleanup branch January 22, 2026 14:28

bsipocz commented Jan 22, 2026

Copy link
Copy Markdown
Member

@bsipocz I modified the release workflow to only hit the upload action on tags, not on PRs with the wheel label.

and thanks for fixing circleci, I forgot to come back to it yesterday.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL