| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
| ] | ||
| ], | ||
| ["Documentation", | ||
| [ |
There was a problem hiding this comment.
At the moment I have just linked the coordinated packages here. We need to decide if we want to list all affiliated packages or not.
As you can see on https://sunpy.org it's possible to have collapsible sections here, so we could choose to put all the affiliated packages under a click to reveal list.
Sorry, something went wrong.
There was a problem hiding this comment.
It should also be noted that by default if we list all the affiliated packages here they will also be included in the unified search results (as long as they are hosted on RTD).
Sorry, something went wrong.
There was a problem hiding this comment.
I think we should restrict ourselves to coordinated packages for now
Sorry, something went wrong.
| ["Team", "team.html", 2], | ||
| ] | ||
| rtd_extra_search_projects = [["astropy-org-test", "https://astropy-org-test.readthedocs.io"]] | ||
| footer_links = [["Code of Conduct", "code_of_conduct.html", 2]] No newline at end of file |
There was a problem hiding this comment.
At the moment I have only put the CoC in the footer.
The footer on astropy.org is quite different before this theme so we might want to customize the footer further.
Sorry, something went wrong.
If you make the base branch the #47 then it all cleans up here, and once that one is merged will be fall back on main. It's a rather nice and convenient recent(ish) GH feature. |
Sorry, something went wrong.
|
I didn't realise you could do that unless the base branch was on the upstream repo. I'll have a look! |
Sorry, something went wrong.
Ah, maybe you are right and we could only do that as I cannot convince my team to use fork-based development 🙄 |
Sorry, something went wrong.
This brings it closer to astropy#48 as well
| ["specreduce", "https://specreduce.readthedocs.io", 3], | ||
| ["specutils", "https://specutils.readthedocs.io", 3], | ||
| ] | ||
| ], |
There was a problem hiding this comment.
docs.astropy.org has a learn link in the header, would we like to add one here?
Sorry, something went wrong.
|
(The CI is failing because of GitHub flakiness) |
Sorry, something went wrong.
|
Also it's way too much orange even though Erik T would probably like it given astropy/astropy#15111 |
Sorry, something went wrong.
|
Just a quick note that I find the new theme quite pleasant -- but then, I've grown up in NL so like the colour orange ... |
Sorry, something went wrong.
I don't think there's an easy way to fix this problem and it doesn't seem to me that it's going to be a big problem? |
Sorry, something went wrong.
Maybe I am outlier but I work with astropy almost exclusively in the dev version, and I confused myself in the first few mins navigating that menu. |
Sorry, something went wrong.
|
That's really interesting to me, I'd never use that menu to get back to the documentation homepage, but now you've said it I can see people doing it. For what it's worth nobody has ever complained about doing this with the sunpy docs 🤷 I've opened this: sunpy/sunpy-sphinx-theme#308 I hope you don't consider this a blocking issue 🙈 |
Sorry, something went wrong.
In that there's too many occurrences of the colour orange or that the orange is too orange? Also light theme or dark? I haven't put a lot of effort into the colouring yet, so I'm happy to tweak things some. However, I also don't have a load of time to prod around with CSS if I want to get this rolled out to all the packages within budget. |
Sorry, something went wrong.
|
Thanks! I don't think it is blocking.
Also non-blocking. Just an observation. Marten seems happy with it. |
Sorry, something went wrong.
|
this looks great. I love the improved discoverability ! |
Sorry, something went wrong.
|
I've now cut a sunpy release, could we merge this and get this released? We can hopefully make further incremental changes easily? |
Sorry, something went wrong.
|
I'll defer the decision to @astrofrog or @bsipocz . I have no objection. Thanks! |
Sorry, something went wrong.
|
I'm also happy to help maintain this package going forward, as half of it is now a thin wrapper on sunpy-sphinx-theme. |
Sorry, something went wrong.
|
No objections from me. |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good to me, minor comments below
Sorry, something went wrong.
| @@ -0,0 +1,11 @@ | |||
| :root { | |||
| /* SunPy Theme Colors */ | |||
There was a problem hiding this comment.
Should this say Astropy?
Sorry, something went wrong.
There was a problem hiding this comment.
The meaning (clearly not that obvious) is that these are the colour variables used by the sunpy theme.
Sorry, something went wrong.
| ] | ||
| ], | ||
| ["Documentation", | ||
| [ |
There was a problem hiding this comment.
I think we should restrict ourselves to coordinated packages for now
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR adds the new theme.
You can see built documentation with this theme in the following places: