Repository navigation
Use the same parameter types as what's defined by GNU crypt_r() - #150
Closed
joegsn wants to merge 1 commit into
Closed
joegsn wants to merge 1 commit into
joegsn wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
its important to note that FreeBSD 12 will not be released until Feb 2019, until then we need to cater for FreeBSD-11 and 10 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Also, this change breaks bcrypt on macos |
Sorry, something went wrong.
Closed
Copy link
Copy Markdown
Collaborator
|
Your proposed changes are in the vendored C implementation that this library uses — please propose them upstream at https://www.openwall.com/crypt/, and then they can be pulled downstream into bcrypt-ruby. Thanks! |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a TrueOS-Desktop (devel release, based on FreeBSD 12-current) installation, it seems that building bcrypt-ruby would generate an error regarding the crypt_r function:
./ow-crypt.h:19:14: error: conflicting types for 'crypt_r' extern char *crypt_r(__CONST char *key, __CONST char *setting, void *data); ^ /usr/include/unistd.h:497:7: note: previous declaration is here char *crypt_r(const char *, const char *, struct crypt_data *);The official GNU crypt_r implementation defines the 3rd parameter as struct crypt_data * as well. The same function appears in FreeBSD, which is my target platform.