FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

FreeBSD 12 support by kirillrdy · Pull Request #166 · bcrypt-ruby/bcrypt-ruby · GitHub

Repository navigation

FreeBSD 12 support - #166

Closed
kirillrdy wants to merge 7 commits into
bcrypt-ruby:masterfrom
kirillrdy:master
Closed

kirillrdy wants to merge 7 commits into
bcrypt-ruby:masterfrom
kirillrdy:master

Conversation

Copy link
Copy Markdown

this is similar to @joegsn approach from #150 but also ensures FreeBSD 11 and most importantly OSX are not broken

Copy link
Copy Markdown
Author

hmm, doesn't actually work ... need more testing

Copy link
Copy Markdown
Author

@sparkymat give it a test. Should be all good now

Copy link
Copy Markdown

I'm also interested in this patch or some form of it making its way into the official gem. For now I have accepted this pull request into my own fork. It works for my environment under macOS, FreeBSD-10.1-RELEASE, FreeBSD-11.1-RELEASE, and FreeBSD-12.0-CURRENT.

FreeBSD 12 is indeed not slated to come out until late October / early November 2018, but in my case I have a rails app that must be vetted against FreeBSD-CURRENT in time for its release and bcrypt compilation is one of the road blocks.

It looks like FreeBSD has already adopted some form of this patch in the ports tree.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212304

Copy link
Copy Markdown
Author

I've rebased against latest master and applied patches similar to
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212304

Let me know what you guys think

tjschuck commented Dec 3, 2018

Copy link
Copy Markdown
Collaborator

Both of your final changes are in the vendored C implementation that this library uses — please propose them upstream at https://www.openwall.com/crypt/, and then they can be pulled downstream into bcrypt-ruby.

Thanks!

tjschuck closed this Dec 3, 2018

Copy link
Copy Markdown

Someone posted this PR's URL as a "Quick Comment" at https://www.openwall.com/crypt/ so I just took a look. To me, the weirdest thing is that you're apparently trying to use this wrapper code intended for use inside a libc in a project that isn't a libc. That's why you're running into issues. Perhaps you should be using crypt_blowfish's native interfaces and not the wrappers.

tymat commented May 1, 2019

Copy link
Copy Markdown

This has not been fixed.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL