| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
I don't think visual-regression-tests failure is related? |
Sorry, something went wrong.
|
Thanks @pllim Indeed, it should be unrelated. Warning: This action is deprecated and no longer maintained. Please use mamba-org/setup-micromamba instead. See `[https://github.com/mamba-org/provision-with-micromamba#migration-to-setup-micromamba`](https://github.com/mamba-org/provision-with-micromamba#migration-to-setup-micromamba%60) for a migration guide. @martinRenou I think some CI 'rot' happened here. I'm guessing you fixed this in another repo already? |
Sorry, something went wrong.
|
Is there a reason to hold up this PR? |
Sorry, something went wrong.
|
Thanks for the PR. Can you try applying the same patch as in jupyter-widgets/ipydatagrid@c46fe5c ? |
Sorry, something went wrong.
|
I believe the mamba stuff is out of scope and I tried to address it over at #1655 |
Sorry, something went wrong.
|
And neat thanks for pointing that out! |
Sorry, something went wrong.
|
Damn, I even commented there last week but couldn't remember. I just rebased from the UI |
Sorry, something went wrong.
so this can build in Python 3.13 Co-authored-by: Derek Homeier <dhomeie@gwdg.de>
Co-authored-by: Maarten A. Breddels <maartenbreddels@gmail.com>
|
meeseeksdev please backport to 0.12.x |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
git checkout 0.12.x git pull
git cherry-pick -x -m1 2b322b20f5fee4ece6a9da0058e781ebdbb0a058
git commit -am 'Backport PR #1653: BLD: Use modern jupyter_packaging'
git push YOURFORK 0.12.x:auto-backport-of-pr-1653-on-0.12.x
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the Still Needs Manual Backport label once the PR gets merged. If these instructions are inaccurate, feel free to suggest an improvement. |
Sorry, something went wrong.
|
@pllim Do you need it backported to 0.12.x? I don't have the bandwidth, we may just go ahead and push final 0.13.0. It has been in alpha for too long. |
Sorry, something went wrong.
|
Hmm I don't remember. @maartenbreddels , is Jdaviz locked into 0.12.x series only? |
Sorry, something went wrong.
|
According to https://github.com/spacetelescope/jdaviz/blob/f552510ee17898fbac60ec3f7d7f6e7819c14912/tox.ini#L56 , maybe not. But I vaguely remember we had issue with your master branch a while ago. Not sure what happened after that. |
Sorry, something went wrong.
|
@maartenbreddels, @martinRenou, the jupyterlab and -packaging updates here are cutting Python <= 3.7 (afaics install is only tested under 3.11) ERROR: Could not find a version that satisfies the requirement jupyterlab==4.* (from versions:
...
3.6.0, 3.6.1, 3.6.2, 3.6.3, 3.6.4, 3.6.5, 3.6.6, 3.6.7, 3.6.8, 4.0.0a0, 4.0.0a1, 4.0.0a3, 4.0.0a4, 4.0.0a6, 4.0.0a7, 4.0.0a8, 4.0.0a9, 4.0.0a10, 4.0.0a11, 4.0.0a12, 4.0.0a13, 4.0.0a14, 4.0.0a15, 4.0.0a16, 4.0.0a17, 4.0.0a18, 4.0.0a19, 4.0.0a20, 4.0.0a21, 4.0.0a22, 4.0.0a23, 4.0.0a24, 4.0.0a25, 4.0.0a26, 4.0.0a27, 4.0.0a28, 4.0.0a29, 4.0.0a30, 4.0.0a31, 4.0.0a32)
ERROR: No matching distribution found for jupyterlab==4.*so 3.6 and 3.7 would have to be removed from the Supported list, or try to relax version requirements as discussed in glue-viz/bqplot-image-gl#111 (comment). |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Use modern jupyter_packaging so this can build in Python 3.13
Example failure log: https://github.com/spacetelescope/jdaviz/actions/runs/11278687750/job/31367720187?pr=3210
xref spacetelescope/jdaviz#3210
cc @maartenbreddels @dhomeier