FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BLD: Use modern jupyter_packaging by pllim · Pull Request #1653 · bqplot/bqplot · GitHub

/ bqplot Public

BLD: Use modern jupyter_packaging - #1653

Merged
martinRenou merged 2 commits into
bqplot:masterfrom
pllim:patch-1
Oct 22, 2024
Merged

BLD: Use modern jupyter_packaging#1653
martinRenou merged 2 commits into
bqplot:masterfrom
pllim:patch-1

Conversation

pllim commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Use modern jupyter_packaging so this can build in Python 3.13

Example failure log: https://github.com/spacetelescope/jdaviz/actions/runs/11278687750/job/31367720187?pr=3210

xref spacetelescope/jdaviz#3210

cc @maartenbreddels @dhomeier

pllim commented Oct 11, 2024

Copy link
Copy Markdown
Contributor Author

I don't think visual-regression-tests failure is related?

Copy link
Copy Markdown
Member

Thanks @pllim

Indeed, it should be unrelated.

Warning: This action is deprecated and no longer maintained. Please use mamba-org/setup-micromamba instead. See `[https://github.com/mamba-org/provision-with-micromamba#migration-to-setup-micromamba`](https://github.com/mamba-org/provision-with-micromamba#migration-to-setup-micromamba%60) for a migration guide.

@martinRenou I think some CI 'rot' happened here. I'm guessing you fixed this in another repo already?

pllim commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

Is there a reason to hold up this PR?

Copy link
Copy Markdown
Member

Thanks for the PR. Can you try applying the same patch as in jupyter-widgets/ipydatagrid@c46fe5c ?

pllim commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

I believe the mamba stuff is out of scope and I tried to address it over at #1655

martinRenou commented Oct 22, 2024
edited
Loading

Copy link
Copy Markdown
Member

And neat thanks for pointing that out!

martinRenou commented Oct 22, 2024
edited
Loading

Copy link
Copy Markdown
Member

Damn, I even commented there last week but couldn't remember.

I just rebased from the UI

pllim and others added 2 commits October 22, 2024 16:22
so this can build in Python 3.13

Co-authored-by: Derek Homeier <dhomeie@gwdg.de>
Co-authored-by: Maarten A. Breddels <maartenbreddels@gmail.com>
martinRenou merged commit 2b322b2 into bqplot:master Oct 22, 2024
pllim deleted the patch-1 branch October 22, 2024 14:35

Copy link
Copy Markdown
Member

meeseeksdev please backport to 0.12.x

pllim commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

Thanks!

lumberbot-app Bot commented Oct 22, 2024

Copy link
Copy Markdown

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.12.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 2b322b20f5fee4ece6a9da0058e781ebdbb0a058
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1653: BLD: Use modern jupyter_packaging'
  1. Push to a named branch:
git push YOURFORK 0.12.x:auto-backport-of-pr-1653-on-0.12.x
  1. Create a PR against branch 0.12.x, I would have named this PR:

"Backport PR #1653 on branch 0.12.x (BLD: Use modern jupyter_packaging)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Copy link
Copy Markdown
Member

@pllim Do you need it backported to 0.12.x?

I don't have the bandwidth, we may just go ahead and push final 0.13.0. It has been in alpha for too long.

pllim commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

Hmm I don't remember. @maartenbreddels , is Jdaviz locked into 0.12.x series only?

pllim commented Oct 22, 2024

Copy link
Copy Markdown
Contributor Author

According to https://github.com/spacetelescope/jdaviz/blob/f552510ee17898fbac60ec3f7d7f6e7819c14912/tox.ini#L56 , maybe not. But I vaguely remember we had issue with your master branch a while ago. Not sure what happened after that.

Copy link
Copy Markdown
Contributor

@maartenbreddels, @martinRenou, the jupyterlab and -packaging updates here are cutting Python <= 3.7 (afaics install is only tested under 3.11)

ERROR: Could not find a version that satisfies the requirement jupyterlab==4.* (from versions:
...
3.6.0, 3.6.1, 3.6.2, 3.6.3, 3.6.4, 3.6.5, 3.6.6, 3.6.7, 3.6.8, 4.0.0a0, 4.0.0a1, 4.0.0a3, 4.0.0a4, 4.0.0a6, 4.0.0a7, 4.0.0a8, 4.0.0a9, 4.0.0a10, 4.0.0a11, 4.0.0a12, 4.0.0a13, 4.0.0a14, 4.0.0a15, 4.0.0a16, 4.0.0a17, 4.0.0a18, 4.0.0a19, 4.0.0a20, 4.0.0a21, 4.0.0a22, 4.0.0a23, 4.0.0a24, 4.0.0a25, 4.0.0a26, 4.0.0a27, 4.0.0a28, 4.0.0a29, 4.0.0a30, 4.0.0a31, 4.0.0a32)
      ERROR: No matching distribution found for jupyterlab==4.*

so 3.6 and 3.7 would have to be removed from the Supported list, or try to relax version requirements as discussed in glue-viz/bqplot-image-gl#111 (comment).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL