Use mamba-org/setup-micromamba for visual job - #1655
Conversation
Sorry, something went wrong.
|
Well, at least it ran to completion now, but has some real comparison failures that are beyond my skills to fix. |
Sorry, something went wrong.
|
The diff is visually very small, maybe it's a animation issue/fluke. @martinRenou any idea what can cause this? A jupyter-lab css variable that changed maybe? |
Sorry, something went wrong.
|
update galata references |
Sorry, something went wrong.
|
Annoying, I think the update script looks at who opened the PR, not who send the message. @martinRenou can you confirm that? And is there a reason for this? |
Sorry, something went wrong.
|
Indeed, that was the proposed fix when a CVE about this was published so I copied it over in all repos. I think the solution in here is nicer (looking at the message author as you suggest): https://github.com/jupytercad/JupyterCAD/blob/main/.github/workflows/update_galata_references.yaml |
Sorry, something went wrong.
martinRenou
left a comment
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
|
meeseeksdev please backport to 0.12.x |
Sorry, something went wrong.
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
git checkout 0.12.x git pull
git cherry-pick -x -m1 1a9e2dd046e0ce1489b8f1dfc7e8ea8d69973342
git commit -am 'Backport PR #1655: Use mamba-org/setup-micromamba for visual job'
git push YOURFORK 0.12.x:auto-backport-of-pr-1655-on-0.12.x
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the Still Needs Manual Backport label once the PR gets merged. If these instructions are inaccurate, feel free to suggest an improvement. |
Sorry, something went wrong.
* ci: use modern micromamba action (backport of #1655) * ci: use nodejs 18 * fiddle with versions * use lockfile * try with a modern yarn, yarn 1 does not respect the lockfile * fix typo * fix: yarn package by default writes package.tgz * ci: upgrade actions * remove space from filename of download artifact * use npm ci because we do not have a yarn.lock file * again setup-micromamba action * use yarn, and update lockfile * activate base needed? * use npx * modern micromamba uses different way for python version * requires env name * wrong env name * more ampersands * bad env name * jlpm instead of yarn? * more jlpm * not using matrix * more jlpm * install playwright needed? * use run * use npx? * remove install playwright? * back to npm install * updates images * updates images * updates images * updates images * updates images * accidently added darwin images
See if this helps.