FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implements logs command by exkson · Pull Request #16 · ceph/ceph-devstack · GitHub

  1. ceph
  2. ceph-devstack

Repository navigation

Implements logs command - #16

Merged
kamoltat merged 13 commits into
ceph:mainfrom
exkson:gsoc-2/implements-logs
Sep 8, 2025
ConversationCommits (13)ChecksFiles changed
Merged

Implements logs command#16
kamoltat merged 13 commits into
ceph:mainfrom
exkson:gsoc-2/implements-logs

Conversation

exkson commented Mar 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR implements logs command for ceph-devstack

Features

  • dump logs of most recent run
  • dump logs for specific run
  • configurable dir through ceph-devstack config path
  • support for specific job if there are many

exkson marked this pull request as ready for review March 20, 2025 23:31
exkson force-pushed the gsoc-2/implements-logs branch from 2fd5e62 to 2545620 Compare March 20, 2025 23:37

exkson commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator Author

Hello @VallariAg @zmc @amathuria here is my proposal for logs command implementation on ceph-devstack. Looking forward to your feedback.

zmc reviewed Apr 16, 2025
View reviewed changes

zmc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for your submission! I like your approach overall. Aside from the specific comments I've made, I'd also like to point out the pathlib library that we use elsewhere in the project; it's quite an improvement over working with os.path!

Comment thread ceph_devstack/__init__.py Outdated
Comment thread ceph_devstack/resources/ceph/utils.py
Comment thread ceph_devstack/resources/test/test_devstack.py Outdated
Comment thread ceph_devstack/resources/ceph/__init__.py Outdated
exkson marked this pull request as draft April 16, 2025 19:11
exkson force-pushed the gsoc-2/implements-logs branch from 2545620 to 1474b7b Compare April 17, 2025 14:35
exkson marked this pull request as ready for review April 21, 2025 20:58

exkson commented Apr 21, 2025

Copy link
Copy Markdown
Collaborator Author

Hello @zmc, I've applied the suggestions. I’d appreciate your feedback when you have a moment. Thanks!

zmc reviewed Apr 23, 2025
View reviewed changes

zmc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for updating based on my feedback - these are good changes :)

Comment thread ceph_devstack/resources/ceph/utils.py
kamoltat approved these changes Sep 8, 2025
View reviewed changes

kamoltat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approved based on Zack's previous comment

kamoltat merged commit fecf208 into ceph:main Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zmc zmc left review comments
kamoltat kamoltat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL