FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implements logs command by exkson · Pull Request #16 · ceph/ceph-devstack · GitHub

  1. ceph
  2. ceph-devstack

Repository navigation

Implements logs command #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kamoltat merged 13 commits into from
Sep 8, 2025
Conversation 11 Commits 13 Checks 0 Files changed
Merged

Implements logs command #16

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f4028dd
wip: add some behavior tests
exkson Mar 20, 2025
00570f0
separate concerns to add more tests
exkson Mar 20, 2025
2726844
fix conflicts with rebase
exkson Mar 20, 2025
182ece3
add short flag for parser args
exkson Mar 20, 2025
4c44e5f
add small improvements
exkson Mar 20, 2025
4a7b2a3
wip: fix break line display in logs dump
exkson Apr 16, 2025
7cb3b5e
replace os.path usage by Path methods
exkson Apr 16, 2025
a014e78
provide more descriptive message on multiple jobs found
exkson Apr 17, 2025
1474b7b
correct test
exkson Apr 17, 2025
77b8416
replace tempfile usage with pytest fixture
exkson Apr 21, 2025
31bd3a9
replace logfile uses with log_file
exkson Apr 21, 2025
a2d41b1
make create_log_file method pytest fixture
exkson Apr 21, 2025
7c8b43b
improve toomanyjobsfound error message
exkson Apr 21, 2025
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Next Next commit
replace tempfile usage with pytest fixture
  • Loading branch information
exkson committed Apr 21, 2025
commit 77b8416db02f00fa002d51e6d26bff37df7ec643
185 changes: 92 additions & 93 deletions ceph_devstack/resources/test/test_devstack.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import os
import io
import contextlib
import tempfile
import random as rd
from datetime import datetime, timedelta
import secrets
Expand Down Expand Up @@ -51,98 +50,98 @@ def test_get_job_id_throws_toomanyjobsfound_on_more_than_one_job(self):
get_job_id(jobs)
assert exc.value.jobs == jobs

async def test_logs_command_display_log_file_of_latest_run(self):
with tempfile.TemporaryDirectory() as data_dir:
config["data_dir"] = data_dir
f = io.StringIO()
content = "custom log content"
now = datetime.now().strftime("%Y-%m-%d_%H:%M:%S")
forty_days_ago = (datetime.now() - timedelta(days=40)).strftime(
"%Y-%m-%d_%H:%M:%S"
)

self.create_logfile(data_dir, timestamp=now, content=content)
self.create_logfile(data_dir, timestamp=forty_days_ago)

with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs()
assert content in f.getvalue()

async def test_logs_display_roughly_contents_of_log_file(self):
with tempfile.TemporaryDirectory() as data_dir:
config["data_dir"] = data_dir
f = io.StringIO()
content = "".join(
secrets.choice(string.ascii_letters + string.digits)
for _ in range(6 * 8 * 1024)
)
now = datetime.now().strftime("%Y-%m-%d_%H:%M:%S")
self.create_logfile(data_dir, timestamp=now, content=content)

with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs()
assert content == f.getvalue()

async def test_logs_command_display_log_file_of_given_job_id(self):
with tempfile.TemporaryDirectory() as data_dir:
config["data_dir"] = data_dir
f = io.StringIO()
content = "custom log message"
now = datetime.now().strftime("%Y-%m-%d_%H:%M:%S")

self.create_logfile(
data_dir,
timestamp=now,
test_type="ceph",
job_id="1",
content="another log",
)
self.create_logfile(
data_dir, timestamp=now, test_type="ceph", job_id="2", content=content
)

with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs(job_id="2")
assert content in f.getvalue()

async def test_logs_display_content_of_provided_run_name(self):
with tempfile.TemporaryDirectory() as data_dir:
config["data_dir"] = data_dir
f = io.StringIO()
content = "custom content"
now = datetime.now().strftime("%Y-%m-%d_%H:%M:%S")
three_days_ago = (datetime.now() - timedelta(days=3)).strftime(
"%Y-%m-%d_%H:%M:%S"
)

self.create_logfile(
data_dir,
timestamp=now,
)
run_name = self.create_logfile(
data_dir,
timestamp=three_days_ago,
content=content,
).split("/")[-3]

with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs(run_name=run_name)
assert content in f.getvalue()

async def test_logs_locate_display_file_path_instead_of_config(self):
with tempfile.TemporaryDirectory() as data_dir:
config["data_dir"] = data_dir
f = io.StringIO()

logfile = self.create_logfile(data_dir)
with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs(locate=True)
assert logfile in f.getvalue()
async def test_logs_command_display_log_file_of_latest_run(self, tmp_path):
data_dir = str(tmp_path)
config["data_dir"] = data_dir
f = io.StringIO()
content = "custom log content"
now = datetime.now().strftime("%Y-%m-%d_%H:%M:%S")
forty_days_ago = (datetime.now() - timedelta(days=40)).strftime(
"%Y-%m-%d_%H:%M:%S"
)

self.create_logfile(data_dir, timestamp=now, content=content)
self.create_logfile(data_dir, timestamp=forty_days_ago)

with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs()
assert content in f.getvalue()

async def test_logs_display_roughly_contents_of_log_file(self, tmp_path):
data_dir = str(tmp_path)
config["data_dir"] = data_dir
f = io.StringIO()
content = "".join(
secrets.choice(string.ascii_letters + string.digits)
for _ in range(6 * 8 * 1024)
)
now = datetime.now().strftime("%Y-%m-%d_%H:%M:%S")
self.create_logfile(data_dir, timestamp=now, content=content)

with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs()
assert content == f.getvalue()

async def test_logs_command_display_log_file_of_given_job_id(self, tmp_path):
data_dir = str(tmp_path)
config["data_dir"] = data_dir
f = io.StringIO()
content = "custom log message"
now = datetime.now().strftime("%Y-%m-%d_%H:%M:%S")

self.create_logfile(
data_dir,
timestamp=now,
test_type="ceph",
job_id="1",
content="another log",
)
self.create_logfile(
data_dir, timestamp=now, test_type="ceph", job_id="2", content=content
)

with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs(job_id="2")
assert content in f.getvalue()

async def test_logs_display_content_of_provided_run_name(self, tmp_path):
data_dir = str(tmp_path)
config["data_dir"] = data_dir
f = io.StringIO()
content = "custom content"
now = datetime.now().strftime("%Y-%m-%d_%H:%M:%S")
three_days_ago = (datetime.now() - timedelta(days=3)).strftime(
"%Y-%m-%d_%H:%M:%S"
)

self.create_logfile(
data_dir,
timestamp=now,
)
run_name = self.create_logfile(
data_dir,
timestamp=three_days_ago,
content=content,
).split("/")[-3]

with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs(run_name=run_name)
assert content in f.getvalue()

async def test_logs_locate_display_file_path_instead_of_config(self, tmp_path):
data_dir = str(tmp_path)

config["data_dir"] = data_dir
f = io.StringIO()
logfile = self.create_logfile(data_dir)
with contextlib.redirect_stdout(f):
devstack = CephDevStack()
await devstack.logs(locate=True)
assert logfile in f.getvalue()

def create_logfile(self, data_dir: str, **kwargs):
Comment thread
exkson marked this conversation as resolved.
Resolved
parts = {
Expand Down
Back | FazBrowse Home | New Git URL