FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make Prettier an optional dependency, update to v3, update config option by beeequeue · Pull Request #1736 · changesets/changesets · GitHub

/ changesets Public

Make Prettier an optional dependency, update to v3, update config option - #1736

Closed
beeequeue wants to merge 11 commits into
changesets:nextfrom
beeequeue:prettier3
ConversationCommits (11)ChecksFiles changed
Closed

Make Prettier an optional dependency, update to v3, update config option#1736
beeequeue wants to merge 11 commits into
changesets:nextfrom
beeequeue:prettier3

Conversation

beeequeue commented Oct 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This PR...

  • updates vitest to the v4 beta, and makes it use rolldown-vite instead of regular vite
    • this was because the currently installed vitest version doesn't support import.meta.resolve
  • updates Prettier to v3
  • re-formats all files
  • moves prettier to optional peer dependencies
  • updates the behavior of the prettier option to handle this better

The prettier option changes are:

  • It now only defaults to true if Prettier is installed (resolved) in the project
  • If it is explicitly set to true the config package will verify that it's installed and show an error message if it isn't.

These ended up being a lot of changes and they should probably be split up into more PRs, let me know if I should do that.

The non-formatting changes are in these files:

  • Add a better error message in the packages that use the peer dependency if Prettier isn't installed

changeset-bot Bot commented Oct 12, 2025 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9dbea54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@changesets/apply-release-plan Major
@changesets/config Major
@changesets/write Major
@changesets/cli Major
@changesets/get-release-plan Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov Bot commented Oct 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.86247% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.71%. Comparing base (fbeb818) to head (74b0455).

Files with missing lines Patch % Lines
packages/config/src/index.ts 78.12% 21 Missing ⚠️
packages/cli/src/commands/add/createChangeset.ts 59.25% 11 Missing ⚠️
packages/cli/src/run.ts 38.88% 11 Missing ⚠️
packages/cli/src/commands/publish/npm-utils.ts 0.00% 9 Missing ⚠️
packages/apply-release-plan/src/index.ts 84.44% 7 Missing ⚠️
...rc/test-utils/get-changelog-entry-with-git-hash.ts 0.00% 7 Missing ⚠️
packages/get-github-info/src/index.ts 36.36% 7 Missing ⚠️
packages/cli/src/commands/init/index.ts 57.14% 6 Missing ⚠️
...ckages/cli/src/commands/publish/publishPackages.ts 57.14% 6 Missing ⚠️
packages/write/src/index.ts 57.14% 6 Missing ⚠️
... and 15 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1736      +/-   ##
==========================================
- Coverage   80.09%   79.71%   -0.38%     
==========================================
  Files          65       65              
  Lines        5008     5033      +25     
  Branches      951      954       +3     
==========================================
+ Hits         4011     4012       +1     
- Misses        992     1016      +24     
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

beeequeue marked this pull request as ready for review October 12, 2025 01:50

bluwy commented Oct 12, 2025

Copy link
Copy Markdown
Member

FYI there's #1639 that makes prettier optional too and supports more formatters, though the PR is not completely ready yet.

I think for this PR, there's a lot of mixed changes here to review. Possibly we can start with a PR that updates prettier to v3 first, and update the formatting of the repo? Maybe it should also set as es5 comma for now to reduce the diff, though personally i'm fine with the new "all" default if @Andarist is also fine of it too.

beeequeue commented Oct 12, 2025

Copy link
Copy Markdown
Member Author

Ah I tried to look through the other PRs but didn't see that one. I started on upgrading vitest in a separate branch in the meantime

beeequeue commented Oct 12, 2025

Copy link
Copy Markdown
Member Author

@bluwy #1737

beeequeue closed this Oct 13, 2025
beeequeue mentioned this pull request Mar 5, 2026
Closed
beeequeue deleted the prettier3 branch March 27, 2026 07:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL