FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ensure that disabled legend style is drawn in the center of the text by etimberg · Pull Request #4318 · chartjs/Chart.js · GitHub

Ensure that disabled legend style is drawn in the center of the text - #4318

Merged
simonbrunel merged 1 commit into
masterfrom
fix/4317
Jun 4, 2017
Merged

Ensure that disabled legend style is drawn in the center of the text #4318
simonbrunel merged 1 commit into
masterfrom
fix/4317

Conversation

etimberg commented Jun 4, 2017

Copy link
Copy Markdown
Member

The text is correctly centered in the box. I also did some minification cleanup in the legend plugin.

Resolves #4317

…and that the text is correctly centered in the box
etimberg added this to the Version 2.7 milestone Jun 4, 2017

Copy link
Copy Markdown
Member

Curious about the before/after rendering of legend label, can you post screenshots?

etimberg commented Jun 4, 2017

Copy link
Copy Markdown
Member Author

Sure.

Before:

After:

Copy link
Copy Markdown
Member

Much better "after" :)

simonbrunel merged commit a930830 into master Jun 4, 2017
simonbrunel deleted the fix/4317 branch June 4, 2017 17:34

rept commented Jun 4, 2017

Copy link
Copy Markdown

Hi,

Much, much better indeed. In your example it seems perfect. When I try it, it still seems to be slightly off, especially with strike-through it's noticeable. Seems the text should be 1 or 2px higher in order to be perfectly aligned with colored box and for the strike to go through the middle.

See here:

and here

These are my settings:

                        responsive: true,
                        maintainAspectRatio: false,
                        legend: {
                            labels: {
                                fontFamily: 'Open Sans',
                                fontSize: 15,
                                padding: 25
                            }

exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Ensure that disabled legend style is drawn in the center of the text and that the text is correctly centered in the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL