Adjust vertical alignment of tooltip items - #6292
Merged
etimberg merged 1 commit intoJun 19, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Closed
benmccann
approved these changes
May 24, 2019
kurkle
approved these changes
May 24, 2019
kurkle
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, just wondering if aligning text would make any sense for displays with device pixel ratio > 1.
Sorry, something went wrong.
Comment thread
src/core/core.tooltip.js
etimberg
approved these changes
May 26, 2019
etimberg
approved these changes
Jun 19, 2019
This was referenced Mar 4, 2020
This was referenced Mar 9, 2020
This was referenced Apr 14, 2020
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
This was referenced Jun 1, 2021
Open
1 task
1 task
This was referenced Jul 27, 2021
This was referenced Oct 14, 2021
1 task
This was referenced Jan 21, 2022
This was referenced Feb 4, 2022
This was referenced Mar 7, 2022
Open
1 task
This was referenced Nov 29, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, texts in a tooltip are aligned to 'top', but some browsers (in particular, Safari on Mac and IE/Edge on Win) add extra space above the texts, and they are shifted down a few pixels as reported in #3393. As the alignment of legend items were fixed in #4318, this PR makes similar changes to tooltip items by using textBaseline = 'middle'.
As shown below, the changes only affect the results in Safari (Mac), IE (Win) and Edge (Win).
Master: https://jsfiddle.net/nagix/v8qhgczu/
This PR: https://jsfiddle.net/nagix/k9gzv5wf/
Fixes #3393