FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add tests and a sample for radar scriptable line options by nagix · Pull Request #6263 · chartjs/Chart.js · GitHub

/ Chart.js Public

Add tests and a sample for radar scriptable line options - #6263

Merged
etimberg merged 2 commits into
chartjs:masterfrom
nagix:issue-6263
May 21, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Add tests and a sample for radar scriptable line options#6263
etimberg merged 2 commits into
chartjs:masterfrom
nagix:issue-6263

Conversation

nagix commented May 11, 2019

Copy link
Copy Markdown
Contributor

#5621 added support for line scriptable options for the radar chart, but unit tests were missing. This PR adds tests and updates the radar chart sample.

kurkle reviewed May 11, 2019
View reviewed changes

kurkle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Couldn't find anything wrong, but didn't go through every thing yet.

nagix mentioned this pull request May 12, 2019
Merged
simonbrunel reviewed May 12, 2019
View reviewed changes

simonbrunel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @nagix for this update, just a minor comment to make the image diff more robust in some cases.

Comment thread test/fixtures/controller.radar/pointBorderColor/scriptable.js
fill: false
},
point: {
borderColor: function(ctx) {

simonbrunel May 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would probably set a higher border width on all these pointBorderColor tests to make sure the image diff will fail in case of a wrong color.

simonbrunel added this to the Version 2.9 milestone May 12, 2019

nagix commented May 20, 2019

Copy link
Copy Markdown
Contributor Author

Updated image tests based on the review comment and #6269.

kurkle previously approved these changes May 20, 2019
View reviewed changes

nagix commented May 21, 2019

Copy link
Copy Markdown
Contributor Author

Rebased and updated image tests based on #6281 and #6282.

etimberg merged commit bd3ab17 into chartjs:master May 21, 2019
nagix deleted the issue-6263 branch May 22, 2019 01:41
snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Add tests and a sample for radar scriptable line options (chartjs#6263)
fa0168e 
* Add tests and a sample for radar scriptable line options

* Improve image tests
renovate Bot mentioned this pull request Jun 1, 2021
Closed
1 task
This was referenced Jun 2, 2021
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
mend-for-github-com Bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
mend-for-github-com Bot mentioned this pull request Jan 26, 2023
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

simonbrunel simonbrunel approved these changes
etimberg etimberg approved these changes
kurkle kurkle approved these changes
+1 more reviewer
benmccann benmccann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: chore

Projects

None yet

Milestone

Version 2.9

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL