FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support boundary filling modes in radialLinear scale by nagix · Pull Request #6281 · chartjs/Chart.js · GitHub

/ Chart.js Public

Support boundary filling modes in radialLinear scale - #6281

Merged
simonbrunel merged 1 commit into
chartjs:masterfrom
nagix:issue-6281
May 21, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Support boundary filling modes in radialLinear scale#6281
simonbrunel merged 1 commit into
chartjs:masterfrom
nagix:issue-6281

Conversation

nagix commented May 16, 2019

Copy link
Copy Markdown
Contributor

In radar charts,

  • if a dataset doesn't have NaN value, the boundary filling mode option ('start, 'end', 'origin') makes no effect
  • if a dataset has NaN value, all boundary modes result in wrong charts

This PR adds support for those boundary filling modes to be consistent with line charts. If a scale has circular grid lines, the boundary will also be in a circular shape.

Master: https://jsfiddle.net/nagix/etkr9p0x/

This PR: https://jsfiddle.net/nagix/onaq4hbm/

kurkle approved these changes May 18, 2019
View reviewed changes

kurkle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

simonbrunel added this to the Version 2.9 milestone May 21, 2019
simonbrunel merged commit cfcdccc into chartjs:master May 21, 2019
simonbrunel mentioned this pull request May 21, 2019
Merged
nagix mentioned this pull request May 21, 2019
Merged
nagix deleted the issue-6281 branch May 21, 2019 16:59
nagix mentioned this pull request Jul 19, 2019
Closed
stockiNail mentioned this pull request Oct 29, 2019
Closed
snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Support boundary filling modes in radialLinear scale (chartjs#6281)
5c5860b
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
mend-for-github-com Bot mentioned this pull request Jul 5, 2021
Closed
1 task
mend-for-github-com Bot mentioned this pull request Jul 5, 2021
Open
1 task
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
mend-for-github-com Bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
mend-for-github-com Bot mentioned this pull request Jan 26, 2023
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

etimberg etimberg approved these changes
kurkle kurkle approved these changes
+1 more reviewer
benmccann benmccann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: enhancement

Projects

None yet

Milestone

Version 2.9

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL