[core] Deprecate ExtModule utility traits - #5102
Merged
seldridge merged 2 commits intoDec 2, 2025
Merged
seldridge merged 2 commits into
seldridge merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
seldridge
marked this pull request as draft
November 28, 2025 00:38
Deprecate all `Param`s and `ExtModule` inside experimental as this is moving into chisel3 proper in Chisel 8. This is insanely difficult to do with `case class`es, but I think we can just deprecate these as so and the result is that all `case class` methods are deprecated and we can just make all these `case class`es normal `class`es in Chisel 8. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Deprecate all the external module utility traits used to add methods for including the source of the blackbox via annotations. There's no point in having these traits and not just putting the methods on `ExtModule` directly. Do this and deprecate the traits. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/deprecate-extmodule-traits
branch
from
78706e1 to
a371189
Compare
November 28, 2025 22:00
seldridge
force-pushed
the
dev/seldridge/deprecate-extmodule-traits-2
branch
from
e783564 to
969a052
Compare
November 28, 2025 22:00
Copy link
Copy Markdown
Contributor
|
LGTM, I think it needs a docs update though. |
Sorry, something went wrong.
Base automatically changed from
dev/seldridge/deprecate-extmodule-traits
to
main
November 29, 2025 00:54
seldridge
marked this pull request as ready for review
November 29, 2025 01:17
jackkoenig
approved these changes
Dec 1, 2025
jackkoenig
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate all the external module utility traits used to add methods for
including the source of the blackbox via annotations. There's no point in
having these traits and not just putting the methods on ExtModule
directly. Do this and deprecate the traits.
This is stacked on #5101.
Release Notes
Deprecate external module "has" traits used to annotate an external module with
the Verilog source. Instead, these methods are moved onto the external module
directly, so there is no need to mix in the traits.