dev(testing): separate unit and e2e tests - #2852
Merged
jsjoeio merged 10 commits intoMar 15, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jsjoeio
marked this pull request as draft
March 9, 2021 23:59
jsjoeio
commented
Mar 10, 2021
Comment thread
.eslintrc.yaml
Outdated
Comment on lines
+35
to
+41
| [ | ||
| error, | ||
| { | ||
| alphabetize: { order: "asc" }, | ||
| groups: [["builtin", "external", "internal"], "parent", "sibling"], | ||
| }, | ||
| ] |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
💄
Sorry, something went wrong.
Comment thread
.eslintrc.yaml
Outdated
Comment thread
test/unit/test-plugin/src/index.ts
Outdated
jsjoeio
force-pushed
the
jsjoeio-2646-separate-testing
branch
from
e09359a to
5a5c78a
Compare
March 10, 2021 19:30
jsjoeio
marked this pull request as ready for review
March 10, 2021 21:24
oxy
reviewed
Mar 11, 2021
oxy
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Not sure about the off -> 0 thing, LGTM otherwise!
Sorry, something went wrong.
Comment thread
.eslintrc.yaml
Outdated
jsjoeio
force-pushed
the
jsjoeio-2646-separate-testing
branch
from
5a5c78a to
7e23575
Compare
March 12, 2021 19:01
oxy
approved these changes
Mar 15, 2021
oxy
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2646 by separating unit and e2e testing. Hopefully this speeds things up with CI.