Update Node to 20.12.1 - #6833
Closed
code-asher wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Merged
The watcher seems to not be catching this...unsure if it is a bug yet.
code-asher
force-pushed
the
asher/node-20.12.1
branch
from
1efd9bd to
57646b4
Compare
June 10, 2024 21:05
Seems the verbiage has changed.
code-asher
force-pushed
the
asher/node-20.12.1
branch
from
57646b4 to
4e7def2
Compare
June 10, 2024 21:25
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #6833 +/- ##
=======================================
Coverage ? 72.77%
=======================================
Files ? 31
Lines ? 1899
Branches ? 410
=======================================
Hits ? 1382
Misses ? 437
Partials ? 80 Continue to review full report in Codecov by Sentry.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I think I finally narrowed the issue down. Seems to have something to do with the display language patch. Experimenting with whether it can be removed or fixed, but this PR is not necessary. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still trying to figure out a failure to connect the first time that reproduces consistently for me.