FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Node to 20.12.1 by code-asher · Pull Request #6833 · coder/code-server · GitHub

/ code-server Public

Update Node to 20.12.1 #6833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
code-asher wants to merge 3 commits into from
Conversation 2 Commits 3 Checks 0 Files changed
Closed

Update Node to 20.12.1 #6833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abe1584
Update Node to 20.12.1
code-asher Jun 10, 2024
ccc5f82
Refresh explorer after creating file
code-asher Jun 10, 2024
4e7def2
Update invalid JSON test
code-asher Jun 10, 2024
File filter

Filter by extension

Filter by extension .md  (1) .ts  (3) dotfile  (1) All 3 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion .node-version
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.11.1
20.12.1
2 changes: 1 addition & 1 deletion CHANGELOG.md
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Code v1.90.0
## Changed

- Updated to Code 1.90.0.
- Updated Node to 20.11.1.
- Updated Node to 20.12.1.

## Added

Expand Down
4 changes: 4 additions & 0 deletions test/e2e/downloads.test.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ describe("Downloads (enabled)", ["--disable-workspace-trust"], {}, async () => {
const workspaceDir = await codeServerPage.workspaceDir
const tmpFilePath = path.join(workspaceDir, "unique-file.txt")
await fs.writeFile(tmpFilePath, "hello world")
await codeServerPage.executeCommandViaMenus("Refresh Explorer")

// Action
const fileInExplorer = await codeServerPage.page.waitForSelector("text=unique-file.txt")
Expand All @@ -30,6 +31,7 @@ describe("Downloads (enabled)", ["--disable-workspace-trust"], {}, async () => {
const fileName = "unique-file-save-as.txt"
const tmpFilePath = path.join(workspaceDir, fileName)
await fs.writeFile(tmpFilePath, "Hello World")
await codeServerPage.executeCommandViaMenus("Refresh Explorer")

// Action
await codeServerPage.page.waitForSelector(`text=${fileName}`)
Expand Down Expand Up @@ -71,6 +73,7 @@ describe("Downloads (disabled)", ["--disable-workspace-trust", "--disable-file-d
const workspaceDir = await codeServerPage.workspaceDir
const tmpFilePath = path.join(workspaceDir, "unique-file.txt")
await fs.writeFile(tmpFilePath, "Hello World")
await codeServerPage.executeCommandViaMenus("Refresh Explorer")

// Action
const fileInExplorer = await codeServerPage.page.waitForSelector("text=unique-file.txt")
Expand All @@ -87,6 +90,7 @@ describe("Downloads (disabled)", ["--disable-workspace-trust", "--disable-file-d
const fileName = "unique-file-save-as.txt"
const tmpFilePath = path.join(workspaceDir, fileName)
await fs.writeFile(tmpFilePath, "Hello World")
await codeServerPage.executeCommandViaMenus("Refresh Explorer")

// Action
await codeServerPage.page.waitForSelector(`text=${fileName}`)
Expand Down
2 changes: 2 additions & 0 deletions test/e2e/uploads.test.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ describe("Uploads (enabled)", ["--disable-workspace-trust"], {}, () => {
const workspaceDir = await codeServerPage.workspaceDir
const tmpDirPath = path.join(workspaceDir, "test-directory")
await fs.mkdir(tmpDirPath)
await codeServerPage.executeCommandViaMenus("Refresh Explorer")

// Action
const fileInExplorer = await codeServerPage.page.waitForSelector('span:has-text("test-directory")')
Expand Down Expand Up @@ -42,6 +43,7 @@ describe("Uploads (disabled)", ["--disable-workspace-trust", "--disable-file-upl
const workspaceDir = await codeServerPage.workspaceDir
const tmpDirPath = path.join(workspaceDir, "test-directory")
await fs.mkdir(tmpDirPath)
await codeServerPage.executeCommandViaMenus("Refresh Explorer")

// Action
const fileInExplorer = await codeServerPage.page.waitForSelector('span:has-text("test-directory")')
Expand Down
2 changes: 1 addition & 1 deletion test/unit/node/settings.test.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe("settings", () => {
const settings = new SettingsProvider<CoderSettings>(pathToMockSettingsFile)
await settings.read()
// This happens when we can't parse a JSON (usually error in file)
expect(logger.warn).toHaveBeenCalledWith("Unexpected token t in JSON at position 29")
expect(logger.warn).toHaveBeenCalledWith("Unexpected token 't', ...\"lloWorld:\"test\"}\" is not valid JSON")
})
})
describe("with invalid settings file path", () => {
Expand Down
Back | FazBrowse Home | New Git URL